Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Symfony has deprecated a load of response and request event classes and we need to update to using the new names. There are no trigger errors because the classes are still part of the inheritance chain. However in order to prep for SF5 we need should do the work.
Comments
Comment #2
alexpottOne interesting question is should we leave the typehints alone for maximum SF4 compatibility?
Comment #3
mikelutzComment #4
klausiPatch does not apply anymore.
Comment #5
klausiComment #6
martin107 CreditAttribution: martin107 as a volunteer commentedI will sort out the reroll.
Comment #7
martin107 CreditAttribution: martin107 as a volunteer commentedreroll.
Comment #8
martin107 CreditAttribution: martin107 as a volunteer commentedFixed a problem common to many failures.
Comment #10
martin107 CreditAttribution: martin107 as a volunteer commentedActiveLinkResponseFilterTest now passes locally.
This is part of a larger thing, but it will be good to use symfony 5
Comment #11
martin107 CreditAttribution: martin107 as a volunteer commentedComment #12
thalles#10 applied with success!
Thanks @martin107!
Comment #13
andypostReroll after #3113876: The "Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent::getException()" method is deprecated since Symfony 4.4, use "getThrowable()" instead
Comment #14
klausiGetResponseEvent and FilterResponseEvent replacements look good.
Looks like we did not catch all TerminateEvent:
Comment #15
klausiSorry for the confusion, I should have checked for PostResponseEvent which was replaced by TerminateEvent.
That also looks good, thanks!
Comment #16
longwavePossible duplicates:
#3113873: Deprecated code in the core/workspaces module
#3113884: Remove usage of deprecated GetResponseEvent and FilterResponseEvent classes
#3114773: Parameter $event of method Drupal\workspaces\EventSubscriber\WorkspaceRequestSubscriber::onKernelController() has typehint with deprecated class
Comment #17
xjmComment #20
catchCommitted/pushed to 9.1.x and cherry-picked to 9.0.x, thanks!