Problem/Motivation

There are a couple of code comments in core/modules/ckeditor that include this:

@see http://docs.cksource.com/CKEditor_3.x/Developers_Guide/Styles

If you follow the link, you land on a big red warning:

This website contains links to software which is either no longer maintained or will be supported only until the end of 2019 (CKFinder 2). For the latest documentation about current CKSource projects, including software like CKEditor 4/CKEditor 5, CKFinder 3, Cloud Services, Letters, Accessibility Checker, please visit the new documentation website.

There's also this link:
* see http://docs.cksource.com/ckeditor_api/symbols/CKEDITOR.resourceManager.h....

Proposed resolution

Update the links to point to the new locations for those docs:

Remaining tasks

  1. Do it
  2. Review
  3. RTBC
  4. Commit

User interface changes

-

API changes

-

Data model changes

-

Release notes snippet

-

CommentFileSizeAuthor
#8 3094047.5_8.interdiff.txt839 bytesdww
#8 3094047-8.patch2.32 KBdww
#6 3094047.2_5.interdiff.txt696 bytesdww
#5 3094047-5.patch2.24 KBdww
#4 3094047-4.dead-docs-screenshot.png291.15 KBdww
#2 3094047-2.patch1.43 KBdww
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww created an issue. See original summary.

dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented
Status: Active » Needs review
FileSize
3094047-2.patch1.43 KB
dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented
Issue summary: View changes
Issue tags: +Quick fix
dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented
FileSize
3094047-4.dead-docs-screenshot.png291.15 KB

Okay, here's what it really looks like. ;)

screenshot of dead documentation page

dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented
FileSize
3094047-5.patch2.24 KB

Grep found one more reference to 'cksource' in all of core (besides assets/vendor/ckeditor).

dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented
FileSize
3094047.2_5.interdiff.txt696 bytes

Forgot interdiff.

Also note: the patch changes a .es6.js file, but only in a comment, so there's no corresponding change to the .js file.

dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented

p.s. Applies cleanly to 9.0.x and 8.9.x branches. Would be a huge waste of bot cycles to show that by queuing for testing. I already feel bad letting #5 run.

dww’s picture

dww
we/he/they
CreditAttribution: dww as a volunteer commented
Issue summary: View changes
FileSize
3094047-8.patch2.32 KB
3094047.5_8.interdiff.txt839 bytes

Since we're fixing it anyway, convert the link from #5 to @see.

Also putting both new links into the summary for verification.

lotyrin’s picture

lotyrin CreditAttribution: lotyrin as a volunteer and at Nerdery commented
Status: Needs review » Reviewed & tested by the community

  • catch committed ea29d98 on 9.0.x 
    Issue #3094047 by dww: @see links in ckeditor module point to deprecated...

  • catch committed 041025d on 8.9.x 
    Issue #3094047 by dww: @see links in ckeditor module point to deprecated...

  • catch committed f5af770 on 8.8.x 
    Issue #3094047 by dww: @see links in ckeditor module point to deprecated...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.0.x/8.9.x/8.8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.