Ok guys I'm currently working on a patch that erradicates all of the PHP5 notices and warnings from the main Drupal core. Expect to see a patch soon, the PHP5 mega patch, that is ;)

CommentFileSizeAuthor
#7 vartesting.patch20.72 KBdeekayen
#5 drupal_10.patch20.18 KBm3avrck
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m3avrck’s picture

This patch incorporates this patch: http://drupal.org/node/28948

And addresses the issues brought up with this patch: http://drupal.org/node/30784

A 4.6.3 version can be found here: http://drupal.org/node/30800

m3avrck’s picture

This patch also fixes this bug (as discovered through an undefined variable): http://drupal.org/node/30807

m3avrck hey anyone familiar with node_access_view_all_nodes() ... i think i found a bug as i'm going through cleaning up undefined variables

drumm m3avrck: I think jonbob, but he is still gone

m3avrck yeah definetly a bug

m3avrck yeah drumm just created this issue: http://drupal.org/node/30807

drumm I'm guessing $node->nid can simply be taken out. I'm not sure a %d or %s will ever make it's way into $sql

chx drumm: re. that node access problem and node->nid , it's a minor bug -- the query has no arguments thus needs no arguments.

chx it's not drumm it's m3avrck

chx m3avrck: so, roll a patch which removes that $node->nid

m3avrck ok thanks chx

chx I think the argument was removed during the fix of the so-called DrupalCon bug :) which moshe pointed out to me and JonBob and me have fixed on site. Real life debugging with those guys were real fun!

chx I am not totally sure though -- but it was related to this function for sure

m3avrck’s picture

This patch also fixes a somewhat incorrect use of PHP getimagesize() : http://us2.php.net/manual/en/function.getimagesize.php ... none of the $attr from list() = getimagesize() are ever used (couldn't find a example when these ever would be used), hence they are always undefined. Additionally, we don't even make use of the $width and $height vars that we define already, this is fixed in this patch as well.

m3avrck’s picture

Looks like that getimagesize() is outside the scope of this patch now, created a seperate issue with patch (coming soon!): http://drupal.org/node/30935

m3avrck’s picture

Status: Active » Needs review
FileSize
20.18 KB

Ok guys here is Phase1 of the PHP5 megapatch. This fixes roughly 60-70% of all the warnings/notices/etc present with PHP5 error_reportin(E_ALL) in place.

Please look over comment and let's get this into HEAD ASAP! I *do not* want to reroll this patch if it gets out of date :) I've also tried not to patch certain core modules waiting on bigger patches (e.g., filter module). So please, comment now and let's get this in right now :)

I'll continue to provide additionally phases of this patch till we can get all issues cleared up. Thanks!

deekayen’s picture

Status: Needs review » Needs work

patch no longer applies to HEAD. I hope to work on getting this patch to work tomorrow (10/21/2005).

deekayen’s picture

Status: Needs work » Needs review
FileSize
20.72 KB

I'm attaching a new patch. I did not bring a lot of drupal_10.patch's node.module changes over to this patch. I'm guessing a lot of why the old patch doesn't work anymore is the new forms api.

I don't understand the change of one line of system.module for $style->prefix, so I've left it out, too. While doing this specific process, I noticed a lot of cases where if statements just do a if($var). I left a lot of them alone because it's hard to tell what exactly the if is testing (i.e. int, string, null, bool) and testing isset(), !empty(), and if($var) are all not exactly the same.

Dries’s picture

Status: Needs review » Active

Committed to HEAD. Marking this active.

magico’s picture

Status: Active » Fixed

I think we can close this one.

Anonymous’s picture

Status: Fixed » Closed (fixed)