Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Ok guys I'm currently working on a patch that erradicates all of the PHP5 notices and warnings from the main Drupal core. Expect to see a patch soon, the PHP5 mega patch, that is ;)
Comment | File | Size | Author |
---|---|---|---|
#7 | vartesting.patch | 20.72 KB | deekayen |
#5 | drupal_10.patch | 20.18 KB | m3avrck |
Comments
Comment #1
m3avrck CreditAttribution: m3avrck commentedThis patch incorporates this patch: http://drupal.org/node/28948
And addresses the issues brought up with this patch: http://drupal.org/node/30784
A 4.6.3 version can be found here: http://drupal.org/node/30800
Comment #2
m3avrck CreditAttribution: m3avrck commentedThis patch also fixes this bug (as discovered through an undefined variable): http://drupal.org/node/30807
Comment #3
m3avrck CreditAttribution: m3avrck commentedThis patch also fixes a somewhat incorrect use of PHP getimagesize() : http://us2.php.net/manual/en/function.getimagesize.php ... none of the $attr from list() = getimagesize() are ever used (couldn't find a example when these ever would be used), hence they are always undefined. Additionally, we don't even make use of the $width and $height vars that we define already, this is fixed in this patch as well.
Comment #4
m3avrck CreditAttribution: m3avrck commentedLooks like that getimagesize() is outside the scope of this patch now, created a seperate issue with patch (coming soon!): http://drupal.org/node/30935
Comment #5
m3avrck CreditAttribution: m3avrck commentedOk guys here is Phase1 of the PHP5 megapatch. This fixes roughly 60-70% of all the warnings/notices/etc present with PHP5 error_reportin(E_ALL) in place.
Please look over comment and let's get this into HEAD ASAP! I *do not* want to reroll this patch if it gets out of date :) I've also tried not to patch certain core modules waiting on bigger patches (e.g., filter module). So please, comment now and let's get this in right now :)
I'll continue to provide additionally phases of this patch till we can get all issues cleared up. Thanks!
Comment #6
deekayen CreditAttribution: deekayen commentedpatch no longer applies to HEAD. I hope to work on getting this patch to work tomorrow (10/21/2005).
Comment #7
deekayen CreditAttribution: deekayen commentedI'm attaching a new patch. I did not bring a lot of drupal_10.patch's node.module changes over to this patch. I'm guessing a lot of why the old patch doesn't work anymore is the new forms api.
I don't understand the change of one line of system.module for $style->prefix, so I've left it out, too. While doing this specific process, I noticed a lot of cases where if statements just do a if($var). I left a lot of them alone because it's hard to tell what exactly the if is testing (i.e. int, string, null, bool) and testing isset(), !empty(), and if($var) are all not exactly the same.
Comment #8
Dries CreditAttribution: Dries commentedCommitted to HEAD. Marking this active.
Comment #9
magico CreditAttribution: magico commentedI think we can close this one.
Comment #10
(not verified) CreditAttribution: commented