https://git.drupalcode.org/project/drupal/blob/8.8.0-alpha1/core/modules...

node_type_form() function does not exist in Drupal 8. I suppose it has been converted to Drupal\node\NodeTypeForm

https://git.drupalcode.org/project/drupal/blob/8.8.0-alpha1/core/modules...

\Drupal\field\Entity\Field class does not exists.

field_ui_entity_info() looks like an implementation of D7 hook_entity_info, however it is not.
https://api.drupal.org/api/drupal/modules%21system%21system.api.php/func...

Those references were added in #2120871: Rename EntityListController to EntityListBuilder. Seems like they were already broken at that moment. So I propose we simply remove them.

CommentFileSizeAuthor
#13 ioterdiff_7_13.txt545 bytesgovind.maloo
#13 3092408-13.patch1.21 KBgovind.maloo
#7 3092408-7.patch1.12 KBravi.shankar
#5 3092408-4.patch1.13 KBravi.shankar
#3 3092408-3.patch1.09 KBravi.shankar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi created an issue. See original summary.

Chi’s picture

Chi CreditAttribution: Chi commented
Issue summary: View changes
Issue tags: +Novice
ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Active » Needs review
FileSize
3092408-3.patch1.09 KB

I have removed.

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs review » Needs work

I think it makes sense to keep reference to Node type form.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3092408-4.patch1.13 KB

I have changed, please review.

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs review » Needs work

field_ui_form_node_type_form_alter()

replaces submit button on node type form with new one. That button is initially created in \Drupal\node\NodeTypeForm::actions(). However, I think it is better to reference the whole form class, not just one particular method.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3092408-7.patch1.12 KB

I have changed it again please review.

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs review » Reviewed & tested by the community

Thank you.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: 3092408-7.patch, failed testing. View results

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Reviewed & tested by the community

Unrelated failures so making it RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Needs work 
  1. +++ b/core/modules/field_ui/src/FieldStorageConfigListBuilder.php
@@ -14,9 +14,6 @@
- * @see \Drupal\field\Entity\Field

    This should point to \Drupal\field\Entity\FieldStorageConfig 

  2. +++ b/core/modules/field_ui/src/FieldStorageConfigListBuilder.php
@@ -14,9 +14,6 @@
- * @see field_ui_entity_info()

    This should point to field_ui_entity_type_build()

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Assigned: Unassigned » ravi.shankar
govind.maloo’s picture

govind.maloo CreditAttribution: govind.maloo at Salsa Digital commented
Status: Needs work » Needs review
FileSize
3092408-13.patch1.21 KB
ioterdiff_7_13.txt545 bytes
pandaski’s picture

pandaski CreditAttribution: pandaski commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/field_ui/src/FieldStorageConfigListBuilder.php
@@ -15,8 +15,8 @@
+ * @see field_ui_entity_type_build()

The new patch #13 reflects the correct func

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Assigned: ravi.shankar » Unassigned
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed fea5442 and pushed to 9.0.x. Thanks!
Committed and pushed 8ac2be218f to 8.9.x and 9db61a7f4c to 8.8.x. Thanks!

Backported to 8.8.x as a docs fix.

  • alexpott committed fea5442 on 9.0.x 
    Issue #3092408 by ravi.shankar, govind.maloo, Chi, alexpott: Fix broken...

  • alexpott committed 8ac2be2 on 8.9.x 
    Issue #3092408 by ravi.shankar, govind.maloo, Chi, alexpott: Fix broken...

  • alexpott committed 9db61a7 on 8.8.x 
    Issue #3092408 by ravi.shankar, govind.maloo, Chi, alexpott: Fix broken...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.