Problem/Motivation

Remove deprecated code from datetime module

  • \DATETIME_STORAGE_TIMEZONE
  • \DATETIME_DATETIME_STORAGE_FORMAT
  • \DATETIME_DATE_STORAGE_FORMAT
  • \datetime_date_default_time
  • \Drupal\datetime\Plugin\migrate\field\d6\DateField
  • \Drupal\datetime\Tests\DateTestBase
  • \Drupal\datetime\Tests\Views\DateTimeHandlerTestBase
  • \Drupal\Tests\datetime\Unit\Plugin\migrate\field\d6\DateFieldLegacyTest
  • \Drupal\Tests\datetime\Unit\Plugin\migrate\field\d6\DateFieldTest

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3091528-6.patch17.49 KBravi.shankar
#4 3091528-4.patch17.53 KBel7cosmos
#2 3091528-2.patch16.36 KBel7cosmos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

el7cosmos created an issue. See original summary.

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
CreditAttribution: el7cosmos as a volunteer and at Alterra commented
Status: Active » Needs review
Parent issue: » #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch
FileSize
3091528-2.patch16.36 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3091528-2.patch, failed testing. View results

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
CreditAttribution: el7cosmos as a volunteer and at Alterra commented
Status: Needs work » Needs review
FileSize
3091528-4.patch17.53 KB
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

$ git apply 3091528-4.patch
error: patch failed: core/modules/datetime/datetime.module:8
error: core/modules/datetime/datetime.module: patch does not apply
error: patch failed: core/modules/datetime/src/Plugin/migrate/field/d6/DateField.php:1
error: core/modules/datetime/src/Plugin/migrate/field/d6/DateField.php: patch does not apply
error: patch failed: core/modules/datetime/src/Tests/DateTestBase.php:1
error: core/modules/datetime/src/Tests/DateTestBase.php: patch does not apply
error: patch failed: core/modules/datetime/src/Tests/Views/DateTimeHandlerTestBase.php:1
error: core/modules/datetime/src/Tests/Views/DateTimeHandlerTestBase.php: patch does not apply

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3091528-6.patch17.49 KB

I have re-rolled patch #4.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Category: Plan » Task
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

This looks good to me.

  • catch committed ac90ec1 on 9.0.x 
    Issue #3091528 by el7cosmos, ravi.shankar: Remove deprecated code from...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed ac90ec1 and pushed to 9.0.x. Thanks!

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Issue tags: -Drupal 9 readiness

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Follow-up #3109746: Remove remaining @deprecated code in the datetime module