The comment in the menu_link_content_install() code says:

Add a higher weight so that menu_link_content_path_alias_update() is called after system_path_alias_update() clears the path alias cache.

This isn't anymore necessary, as system_path_alias_update() doesn't exist and its code has not been moved to another hook.

menu_link_content_install() can be removed.

CommentFileSizeAuthor
#4 remove-menu-link-content-install.patch921 bytesvints24
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kiamlaluno created an issue. See original summary.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Issue summary: View changes
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Version: 8.8.x-dev » 8.9.x-dev

I apologize: The link in the documentation page created the issue with the wrong version, and I didn't notice it.

vints24’s picture

vints24 CreditAttribution: vints24 as a volunteer and commented
FileSize
remove-menu-link-content-install.patch921 bytes

I am at Amsterdam 2019 (DrupalCon) and am proposing this patch if the function will be removed.

StevenAvelino’s picture

StevenAvelino CreditAttribution: StevenAvelino as a volunteer commented

After reviewing it, the patch removes the function that was asked to be removed.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Issue summary: View changes
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Active » Needs review
Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan at LimoenGroen commented

This issue removes a function from menu_link_content.install. Is this BC breaking or is any *.install file part of "The installer" as in the D8 DC policy https://www.drupal.org/core/d8-bc-policy and therefore considered @internal?

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented

Hook implementations should not be considered part of the Drupal API, which means that no module should assume there is a menu_link_content_install() function and call it directly.

vints24’s picture

vints24 CreditAttribution: vints24 as a volunteer and commented

@kiamlaluno,

This change is necessary or not for the 8.9.x?
Or need to do something else?

Thanks

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Title: Remove menu_link_content_install() » Remove menu_link_content_install() because it's no longer needed
Category: Task » Bug report
Status: Needs review » Reviewed & tested by the community

@kiamlaluno is correct in #9, I think this patch is good to go on all supported branches, including 8.8.x.

Also, reclassifying as a bug because this is removing dead code.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Category: Bug report » Task
Status: Reviewed & tested by the community » Fixed

I don't think this is a bug fix per se.

Committed and pushed 80b5dd6b08 to 9.0.x and 9455fc7a15 to 8.9.x. Thanks!

  • alexpott committed 80b5dd6 on 9.0.x 
    Issue #3091469 by vints24, kiamlaluno: Remove menu_link_content_install...

  • alexpott committed 9455fc7 on 8.9.x 
    Issue #3091469 by vints24, kiamlaluno: Remove menu_link_content_install...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.