Adding a patch for D9 compatibility

CommentFileSizeAuthor
#10 3091218-drupal-9-compact-10.patch1.43 KBdan2k3k4
drupal-9-compat.patch357 bytesdan2k3k4
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dan2k3k4 created an issue. See original summary.

gbyte’s picture

gbyte CreditAttribution: gbyte as a volunteer and at gbyte commented
Status: Active » Needs review
tomvanetten’s picture

tomvanetten CreditAttribution: tomvanetten as a volunteer commented
Status: Needs review » Reviewed & tested by the community

This patch seems fine and works as expected in drupal 9. Approved !

gbyte’s picture

gbyte CreditAttribution: gbyte as a volunteer and at gbyte commented
Status: Reviewed & tested by the community » Needs work

Is this test expected to fail for D9? This is the first time I set the test runner to use D9 so no idea where things are right now.

dan2k3k4’s picture

dan2k3k4 CreditAttribution: dan2k3k4 at Amazee Labs commented

@gbyte.co hmm, I think it should pass - perhaps the core tag needs to be bumped to 9x for the test runner?

I am just currently trying to get all modules for one project to be "D9 ready" so that I can update the site to D9 dev channel, so I've sent similar "fix" for a couple other modules:
- https://www.drupal.org/project/upgrade_status/issues/3091221
- https://www.drupal.org/project/address/issues/3091232

tomvanetten’s picture

tomvanetten CreditAttribution: tomvanetten as a volunteer commented

composer cannot require the module as the module without the patch is not d9 compatible, and the patch is applied after requiring the module. So it seems a bit of a catch 22 story to me, we require a module to patch in a d9 installation, but the module is not d9 compatible w/o the patch.

Also this is my first time seeing the d9 runner, other contribs were satisfied with a d8 runner and went on. (even before the d9 runnen was available)

tomvanetten’s picture

tomvanetten CreditAttribution: tomvanetten as a volunteer commented
Status: Needs work » Needs review
gbyte’s picture

gbyte CreditAttribution: gbyte as a volunteer and at gbyte commented

Also this is my first time seeing the d9 runner

As I mentioned above same goes for me.

other contribs were satisfied with a d8 runner and went on. (even before the d9 runnen was available)

This statement does not make much sense. Also I can't imagine these 'contribs' being satisfied with a one-liner patch, I'd say they were merely tolerating it. ;)

gbyte’s picture

gbyte CreditAttribution: gbyte as a volunteer and at gbyte commented
Status: Needs review » Needs work

I am guessing submodules need to have that tag as well?

dan2k3k4’s picture

dan2k3k4 CreditAttribution: dan2k3k4 at Amazee Labs commented
FileSize
3091218-drupal-9-compact-10.patch1.43 KB

Updated patch to include the 2 sub-modules

dan2k3k4’s picture

dan2k3k4 CreditAttribution: dan2k3k4 at Amazee Labs commented
Status: Needs work » Needs review

  • gbyte.co committed 9e82c71 on 8.x-3.x 
    Issue #3091218 by dan2k3k4, gbyte.co: Drupal 9 Compatibility
gbyte’s picture

gbyte CreditAttribution: gbyte as a volunteer and at gbyte commented
Status: Needs review » Fixed

I added the key to the test submodule as well. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.