Report generated by drupal-check (https://github.com/mglaman/drupal-check):
------ --------------------------------------------------------------------------
Line office_hours.install
------ --------------------------------------------------------------------------
28 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
45 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
------ --------------------------------------------------------------------------
------ -------------------------------------------------------------------------------
Line office_hours.module
------ -------------------------------------------------------------------------------
86 Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode:
in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
mb_strlen() instead.
------ -------------------------------------------------------------------------------
Comment | File | Size | Author |
---|---|---|---|
#5 | 3091085-5.patch | 572 bytes | Sahana _N |
|
Comments
Comment #2
robindh CreditAttribution: robindh at Anvil commentedWoops, I ran the check on the wrong version of the module. Seems like everything is fixed on the dev branch; which means the module looks d9 ready! Closing this issue.
Comment #3
MatroskeenAt least, we need to add core_version_requirement in info.yml file: https://www.drupal.org/node/3070687
Comment #4
Sahana _N CreditAttribution: Sahana _N at Specbee commentedComment #5
Sahana _N CreditAttribution: Sahana _N at Specbee commentedPlease review the patch.
Comment #6
borisson_This easy fix will add d9 compatibility, +1
Comment #7
johnvThanks, I'll check this the upcoming week, once I have installed a D9 test-site.
Comment #8
JeroenTComment #9
JeroenTThis was fixed in #3131510: Add D9-compatibility to .info.yml file.
Comment #10
johnvStill needs the strlen() change from OP.
Comment #11
JeroenTComment #13
johnvComment #14
johnv