Report generated by drupal-check (https://github.com/mglaman/drupal-check):

------ --------------------------------------------------------------------------
Line office_hours.install
------ --------------------------------------------------------------------------
28 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
45 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
------ --------------------------------------------------------------------------

------ -------------------------------------------------------------------------------
Line office_hours.module
------ -------------------------------------------------------------------------------
86 Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode:
in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
mb_strlen() instead.
------ -------------------------------------------------------------------------------

CommentFileSizeAuthor
#5 3091085-5.patch572 bytesSahana _N
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

robindh created an issue. See original summary.

robindh’s picture

Status: Active » Closed (works as designed)

Woops, I ran the check on the wrong version of the module. Seems like everything is fixed on the dev branch; which means the module looks d9 ready! Closing this issue.

Matroskeen’s picture

Assigned: robindh » Unassigned
Status: Closed (works as designed) » Needs work

At least, we need to add core_version_requirement in info.yml file: https://www.drupal.org/node/3070687

Sahana _N’s picture

Assigned: Unassigned » Sahana _N
Sahana _N’s picture

Status: Needs work » Needs review
FileSize
572 bytes

Please review the patch.

borisson_’s picture

Status: Needs review » Reviewed & tested by the community

This easy fix will add d9 compatibility, +1

johnv’s picture

Thanks, I'll check this the upcoming week, once I have installed a D9 test-site.

JeroenT’s picture

Assigned: Sahana _N » Unassigned
JeroenT’s picture

Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#3131510: Add D9-compatibility to .info.yml file
johnv’s picture

Status: Closed (duplicate) » Needs review

Still needs the strlen() change from OP.

JeroenT’s picture

Status: Needs review » Needs work

  • johnv committed d4c23d8 on 8.x-1.x
    Issue #3091085 by robindh: Drupal 9 Deprecated Code Report
    
johnv’s picture

Status: Needs work » Fixed
johnv’s picture

Version: 8.x-1.x-dev » 8.x-1.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.