Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Finder's exclude
is overly aggressive. It finds any vendor folder (as an example) and excludes it. That means thinks like #3088095: Automatic Updates isn't ready to handle composer sites, but has 3rd party dependencies of its own where we are trying to bundle php-signify in a vendor folder as part of the project fall on their face in build tests.
Proposed resolution
Switch to use notPath
instead.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#8 | 3088400-8.patch | 3.23 KB | heddn |
#8 | interdiff_4-8.txt | 517 bytes | heddn |
Comments
Comment #2
heddnProbably needs more tests, but let's see how things go to begin with.
Comment #3
heddnAnd here's some tests.
Comment #5
heddnphpcs
Comment #8
heddnComment #9
Mile23LGTM.
The tests still demonstrate that we didn't copy the root vendor directory.
Comment #10
alexpottCommitted and pushed 3b6698e973 to 9.0.x and aa9d5a31dd to 8.9.x. Thanks!
Will backport once 8.8.x code freeze is over.
+1
Comment #13
alexpottDiscussed with @catch we agreed this was good to backport to 8.8.x