Problem/Motivation

FileTransferAuthorizeFormTest and UpdateUploadTest are failing on 9.0.x because the zip files they use contain info.yml files with

core: 8.x

Proposed resolution

core_version_requirement: '*'

So we don't have to think about this again.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3088127-2.patch3.38 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Active » Needs review
FileSize
3088127-2.patch3.38 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Parent issue: » #3087874: [meta] Make 9.0.x branch pass testbot
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Title: Fix FileTransferAuthorizeFormTest on 9.0.x » Fix FileTransferAuthorizeFormTest and UpdateUploadTest on 9.0.x
Issue summary: View changes
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Trivial patch of the month

Binary patch, because it changes .zip files. Applied patch. Confirmed that it does what it says in the issue summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

I actually extracted the files and compared them to make sure that @alexpott isn't trying to sneak something into core in a compressed file :p

(And was too slow doing that, so cross-posted with Wim)

I also did run the two tests and they passed, so we should be down to 1 test fail?

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3088127-2.patch, failed testing. View results

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Reviewed & tested by the community

Down to 1 fail, as expected!

  • xjm committed 1a44bab on 9.0.x 
    Issue #3088127 by alexpott, Berdir, Wim Leers: Fix...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

Documenting the diff of the extracted thingers could have been handy, but I trust the reviewers here.

Committed and pushed to 9.0.x Unsure if we want to backport to 8.9.x or not; we didn't for the other test changes as yet. Marking fixed for now, I guess.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 9.0.x-dev » 8.9.x-dev
Status: Fixed » Reviewed & tested by the community

Looks like a backport patch has been posted to #3072702: Core extensions should not need to specify the new core_version_requirement in *.info.yml files so that 9.0.x can be installed, so leaving RTBC against 8.9.x for now pending that, and queueing tests against 8.9.x and 8.8.x just to be safe.

  • catch committed d4d2ada on 8.9.x authored by xjm 
    Issue #3088127 by alexpott, Berdir, Wim Leers: Fix...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

That's been backported now, so cherry-picked to 8.9.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.