Problem/Motivation

Tests against 9.0.x have shown that \Drupal\FunctionalTests\Installer\InstallerExistingConfigTest has a dependency on localize.drupal.org. Our tests shouldn't do that.

Proposed resolution

Create a local translation file.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#2 8.9.x-3088012-2.patch1.37 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 8.8.x-dev » 8.9.x-dev
Status: Active » Needs review
FileSize
8.9.x-3088012-2.patch1.37 KB

This will allow the test to pass on 9.0.x and also pass when l.d.o is down or you are running the test whilst offline.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer and at ICON Interactive commented
Priority: Normal » Critical
Parent issue: » #3087874: [meta] Make 9.0.x branch pass testbot
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented 
+++ b/core/tests/Drupal/FunctionalTests/Installer/InstallerExistingConfigTest.php
@@ -12,12 +12,22 @@ class InstallerExistingConfigTest extends InstallerExistingConfigTestBase {
-  public function setUpSite() {
...
+  public function setUpSettings() {
     // The configuration is from a site installed in French.
     // So after selecting the profile the installer detects that the site must
     // be installed in French, thus we change the button translation.
     $this->translations['Save and continue'] = 'Enregistrer et continuer';
-    parent::setUpSite();
+    parent::setUpSettings();
   }

This change from setUpSite to setUpSettings is slightly fun - it appears that when translations are available we're able to use them slightly earlier - which is fine as the main point of the test is upheld...

ie.

// The configuration is from a site installed in French.
// So after selecting the profile the installer detects that the site must
// be installed in French, thus we change the button translation.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Assigned: Unassigned » Gábor Hojtsy
Issue tags: +Drupal 9, +D8MI, +hardening

I'm sure @Gábor Hojtsy will have thoughts about this :)

To me, this looks great!

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Agreed, this looks fine. Leaving assigned to Gabor, then he can just commit it if he wants to :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Assigned: Gábor Hojtsy » Unassigned

Totally agree with this, we should not be testing your internet connection :) I may be able to commit later. Busy with something else now, so will let others take it if they reach it sooner :)

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer and at ICON Interactive commented

Now that #3072702: Core extensions should not need to specify the new core_version_requirement in *.info.yml files so that 9.0.x can be installed is in, this should reduce test failures on 9.0.x from the current 8.

  • Gábor Hojtsy committed 48cfce3 on 9.0.x 
    Issue #3088012 by alexpott, mikelutz, Wim Leers, Berdir:...

  • Gábor Hojtsy committed 9286e7c on 8.9.x 
    Issue #3088012 by alexpott, mikelutz, Wim Leers, Berdir:...

  • Gábor Hojtsy committed 0250d8c on 8.8.x 
    Issue #3088012 by alexpott, mikelutz, Wim Leers, Berdir:...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

Superb, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.