Prepare for Drupal 9 by removing usage of deprecated code [#3087355]

Please find the .patch file below.

Check performed by "drupal-check".

 4/4 [============================] 100%

 ------ ------------------------------------------------------------------------
  Line   tests\src\Kernel\SubPathautoKernelTest.php                             
 ------ ------------------------------------------------------------------------
  17     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in class 
         Drupal\Tests\subpathauto\Kernel\SubPathautoKernelTest.                 
 ------ ------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------
  Line   tests\src\Unit\SubPathautoTest.php                                     
 ------ -------------------------------------------------------------------------
  72     Call to deprecated method getMock() of class Drupal\Tests\UnitTestCase.
  77     Call to deprecated method getMock() of class Drupal\Tests\UnitTestCase.
  79     Call to deprecated method getMock() of class Drupal\Tests\UnitTestCase.
  81     Call to deprecated method getMock() of class Drupal\Tests\UnitTestCase.
 ------ -------------------------------------------------------------------------

                                                                                
 [ERROR] Found 5 errors

Comment	File	Size	Author
#22	3087355-fix-d9-tests.patch	13.24 KB	dave reid
#16	3087355-d9-compatible.patch	8.15 KB	dave reid
#16	3087355-interdiff.txt	3.74 KB	dave reid
#13	subpathauto-drupal9-compatibility-3087355-13.patch	5.49 KB	angela_g
#12	subpathauto-drupal9-compatibility-3087355-12.patch	4.55 KB	angela_g
#11	subpathauto-drupal9-compatibility-3087355-11.patch	4.21 KB	angela_g
#8	3087355-8.patch	1.83 KB	ravi.shankar
#4	1-subpathauto-drupal-9-compatibility.patch	1.8 KB	angela_g
	1-subpathauto-drupal-9-compatibility.patch	1.8 KB	angela_g

Comments

Comment #1

11 October 2019 at 10:51

angela_G created an issue. See original summary.

Comment #2

angela_g commented 11 October 2019 at 10:52

Issue summary:

View changes

Comment #3

angela_g commented 11 October 2019 at 11:22

1 file was hidden/shown/deleted

Status	File	Size
hidden	1-subpathauto-drupal-9-compatibility.patch	1.8 KB

Comment #4

angela_g commented 11 October 2019 at 11:27

Status	File	Size
new	1-subpathauto-drupal-9-compatibility.patch	1.8 KB

Comment #5

angela_g commented 11 October 2019 at 11:32

Status:

Active

» Needs review

Comment #6

manafov_mehman commented 25 October 2019 at 11:27

Status:

Needs review

» Reviewed & tested by the community

Comment #7

lauriii

he/him

Finnish

Finland

commented 25 November 2019 at 10:45

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs reroll

The patch doesn't apply anymore 😓

Comment #8

ravi.shankar commented 9 January 2020 at 12:21

Status:

Needs work

» Needs review

Status	File	Size
new	3087355-8.patch	1.83 KB

I have re-rolled patch #4.

Comment #9

rpayanm

he/him

Spanish

commented 12 January 2020 at 16:54

Issue tags:

-Needs reroll

Comment #10

aliaksandr_rozum commented 28 January 2020 at 14:32

Status:

Needs review

» Needs work

Hi @ravi.shankar!

There are some deperecated classes in the tests:

 36x: The \Drupal\Core\PathProcessor\PathProcessorAlias class is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Instead, use \Drupal\path_alias\PathProcessor\AliasPathProcessor. See https://drupal.org/node/3092086
    15x in SubPathautoFunctionalTest::testBasicIntegration from Drupal\Tests\subpathauto\Functional
    11x in SubPathautoFunctionalTest::testWithLanguagePrefix from Drupal\Tests\subpathauto\Functional
    10x in SubPathautoFunctionalTest::testNonExistingPath from Drupal\Tests\subpathauto\Functional

  3x: Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.
    1x in SubPathautoFunctionalTest::testBasicIntegration from Drupal\Tests\subpathauto\Functional
    1x in SubPathautoFunctionalTest::testWithLanguagePrefix from Drupal\Tests\subpathauto\Functional
    1x in SubPathautoFunctionalTest::testNonExistingPath from Drupal\Tests\subpathauto\Functional

  3x: \Drupal\Core\Path\AliasStorage is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use the "path_alias.repository" service instead, or the entity storage handler for the "path_alias" entity type for CRUD methods. See https://www.drupal.org/node/3013865.
    1x in SubPathautoFunctionalTest::testBasicIntegration from Drupal\Tests\subpathauto\Functional
    1x in SubPathautoFunctionalTest::testWithLanguagePrefix from Drupal\Tests\subpathauto\Functional
    1x in SubPathautoFunctionalTest::testNonExistingPath from Drupal\Tests\subpathauto\Functional

And core_version_requirement key is need to be updated (https://www.drupal.org/node/3070687)

Comment #11

angela_g commented 5 February 2020 at 13:16

Status	File	Size
new	subpathauto-drupal9-compatibility-3087355-11.patch	4.21 KB

Fixed deprecated classes in the tests.

Comment #12

angela_g commented 5 February 2020 at 13:22

Status	File	Size
new	subpathauto-drupal9-compatibility-3087355-12.patch	4.55 KB

Fixed deprecated classes in the tests and added "core_version_requirement" to info.yml.

Comment #13

angela_g commented 5 February 2020 at 16:46

Status	File	Size
new	subpathauto-drupal9-compatibility-3087355-13.patch	5.49 KB

Comment #14

angela_g commented 5 February 2020 at 16:52

Status:

Needs work

» Needs review

Comment #15

aliaksandr_rozum commented 18 February 2020 at 14:19

Status:

Needs review

» Reviewed & tested by the community

Hi @angela_G,
your patch look's good:

docker@cli:/var/www$ vendor/bin/phpunit -c web/core/ web/modules/contrib/subpathauto/
PHPUnit 7.5.20-3-gfc43f121f by Sebastian Bergmann and contributors.

Testing web/modules/contrib/subpathauto/
...........                                                       11 / 11 (100%)

Time: 3.62 minutes, Memory: 10.00 MB

OK (11 tests, 72 assertions)
docker@cli:/var/www$ drupal-check web/modules/contrib/subpathauto/
 6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 [OK] No errors

Comment #16

dave reid

he/him

English

Nebraska USA

commented 21 May 2020 at 15:37

Status	File	Size
new	3087355-interdiff.txt	3.74 KB
new	3087355-d9-compatible.patch	8.15 KB

Fixing some coding standards.

Comment #17

dave reid

he/him

English

Nebraska USA

commented 21 May 2020 at 15:48

Comment #18

21 May 2020 at 15:49

Dave Reid committed 13b5d70 on 8.x-1.x

Issue #3087355 by angela_G, Dave Reid, ravi.shankar, aliaksandr_rozum:...

Comment #19

dave reid

he/him

English

Nebraska USA

commented 21 May 2020 at 15:50

Status:

Reviewed & tested by the community

» Fixed

Committed #16 to 8.x-1.x. Thanks everyone!

Comment #20

21 May 2020 at 16:20

Dave Reid committed 4ebdd29 on 8.x-1.x

Issue #3087355 by Dave Reid: Replaced path.alias_whitelist with...

Comment #21

dave reid

he/him

English

Nebraska USA

commented 21 May 2020 at 16:22

I managed to run the automated tests against D9 and found we were still using the deprecated service path.alias_whitelist. I have replaced them with using path_alias.whitelist in the latest 8.x-1.x.

Comment #22

dave reid

he/him

English

Nebraska USA

commented 21 May 2020 at 16:35

Status:

Fixed

» Needs review

Status	File	Size
new	3087355-fix-d9-tests.patch	13.24 KB

More fixes for Drupal 9 testing, and fixing variables that don't make sense.

Comment #23

21 May 2020 at 16:45

Dave Reid committed e20527d on 8.x-1.x

Issue #3087355 by Dave Reid: Fixing tests on Drupal 9.

Comment #24

dave reid

he/him

English

Nebraska USA

commented 21 May 2020 at 16:45

Status:

Needs review

» Fixed

Committed #22 to 8.x-1.x. Now tests are fully passing on Drupal 9, hooray!

Comment #25

dave reid

he/him

English

Nebraska USA

commented 21 May 2020 at 19:24

Comment #26

4 June 2020 at 19:24

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Prepare for Drupal 9 by removing usage of deprecated code

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

Comment #26

News items

Our community

Documentation

Drupal code base

Governance of community