Problem/Motivation

Recent changes to migration lookup can cause a PluginNotFoundException to be thrown when previously a silent error would be passed through.

Proposed resolution

Catch this exception and silence it to preserve previous behavior.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3086952-2.drupal.patch5.41 KBmikelutz
#3 3086952-2.drupal.TEST_ONLY.patch4.62 KBmikelutz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikelutz created an issue. See original summary.

mikelutz credited quietone.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer and at ICON Interactive commented
Status: Active » Needs review
FileSize
3086952-2.drupal.TEST_ONLY.patch4.62 KB
3086952-2.drupal.patch5.41 KB

A slightly refactored test from #3004927-59: Create Migration Lookup and Stub services, and a fix.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer and at ICON Interactive commented
Title: Migration Lookup should catch PluginNotFound Exceptions and ignore them. » Migration Lookup should catch PluginNotFoundException exceptions and ignore them.
Assigned: mikelutz » Unassigned
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer and at ICON Interactive commented
Issue summary: View changes

The last submitted patch, 3: 3086952-2.drupal.TEST_ONLY.patch, failed testing. View results

acbramley’s picture

acbramley CreditAttribution: acbramley at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

Code looks good to me, might be worth linking to the changes that removed the exception handling in the IS?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed 5a7951f and pushed to 8.8.x. Thanks!

Thanks all

  • larowlan committed 5a7951f on 8.8.x 
    Issue #3086952 by mikelutz, quietone: Migration Lookup should catch...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.