Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
To help avoid bugs like #3086804: Too few arguments to function DropzoneJsEbWidget::__construct, add some basic test coverage to eb_widget submodule.
Comment | File | Size | Author |
---|---|---|---|
#32 | 3086881-coverage-eb-widget-31.patch | 20.96 KB | Primsi |
#30 | 3086881-coverage-eb-widget-30.patch | 1.04 KB | Primsi |
#26 | 3086881-coverage-eb-widget-26.patch | 20.99 KB | Primsi |
#23 | 3086881-coverage-eb-widget-23.diff | 20.98 KB | Primsi |
#23 | 3086881-coverage-eb-widget-23.interdiff.txt | 1.56 KB | Primsi |
Comments
Comment #2
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedWe could use that in #3083640: Check before adding the result of createFile to the entity list too. Started working on it.
Comment #3
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedFinally had time for this. First try at this.
Comment #4
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedAs per @Berdir suggestion, adding the library via drupaci.yml. Not sure if only new commands need to be added or we need to override the whole default thing. Let's see.
Comment #5
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #6
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #7
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #8
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #9
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #10
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #11
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #12
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #13
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #14
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #15
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented...
Comment #16
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #17
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedFinally. Seems only deprication now remains. Sry for all the spamming.
Comment #18
BerdirI would switch this to true.
Deprecations shouldn't fail tests, you can't have zero deprecations against 8.8 without hacks for 8.7.
And there might be new deprecations at any moment, which would suddenly cause test fails.
Comment #19
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #20
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedYay, thanks @Berdir
Comment #21
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #22
Berdirconfused by this, a test module doesn't need a composer.json? seems like it is just a copy of the main one?
when touching this anyway, you do might want to add the core_version_requirement: ^8 || ^9 already though, one thing less to fix, and the version: VERSION is also bogus, remove.
Comment #23
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedAddressed 1. Ignored 2. per chat :)
Comment #25
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #26
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedRerolling.
Comment #27
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedUm,... here it passed, but now head is failing.
Comment #28
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedLooks like testbot ignores our drupalci?
> This build does not contain a modified drupalci.yml file. Using existing assessment stage.
Comment #30
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedChanging commands syntax.
Comment #32
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedLet's retry with 8.x-1.x. now.
Comment #33
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedEh, of course not,... doing that on autopilot.