Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

Primsi’s picture

Assigned: Unassigned » Primsi

We could use that in #3083640: Check before adding the result of createFile to the entity list too. Started working on it.

Primsi’s picture

Status: Active » Needs review
FileSize
19.79 KB

Finally had time for this. First try at this.

Primsi’s picture

As per @Berdir suggestion, adding the library via drupaci.yml. Not sure if only new commands need to be added or we need to override the whole default thing. Let's see.

Primsi’s picture

Primsi’s picture

Primsi’s picture

Primsi’s picture

Primsi’s picture

Primsi’s picture

Primsi’s picture

Primsi’s picture

Primsi’s picture

Primsi’s picture

Primsi’s picture

Primsi’s picture

Primsi’s picture

Finally. Seems only deprication now remains. Sry for all the spamming.

Berdir’s picture

+++ b/drupalci.yml
@@ -0,0 +1,66 @@
+        suppress-deprecations: false
...
+        suppress-deprecations: false
...
+        suppress-deprecations: false
...
+        suppress-deprecations: false

I would switch this to true.

Deprecations shouldn't fail tests, you can't have zero deprecations against 8.8 without hacks for 8.7.

And there might be new deprecations at any moment, which would suddenly cause test fails.

Primsi’s picture

Primsi’s picture

Yay, thanks @Berdir

Primsi’s picture

Berdir’s picture

Status: Needs review » Needs work
  1. +++ b/drupalci.yml
    --- /dev/null
    +++ b/tests/modules/dropzonejs_test/composer.json
    
    +++ b/tests/modules/dropzonejs_test/composer.json
    +++ b/tests/modules/dropzonejs_test/composer.json
    @@ -0,0 +1,44 @@
    
    @@ -0,0 +1,44 @@
    +{
    +  "name": "drupal/dropzonejs",
    +  "description": "Drupal integration for DropzoneJS - An open source library that provides drag’n’drop file uploads with image previews.",
    +  "type": "drupal-module",
    +  "homepage": "https://www.drupal.org/project/dropzonejs",
    +  "keywords": ["Drupal", "DropzoneJS"],
    +  "license": "GPL-2.0+",
    

    confused by this, a test module doesn't need a composer.json? seems like it is just a copy of the main one?

  2. +++ b/tests/modules/dropzonejs_test/dropzonejs_test.info.yml
    @@ -5,4 +5,6 @@ package: Testing
     version: VERSION
     core: 8.x
     dependencies:
    + - drupal:media
      - dropzonejs:dropzonejs
    + - dropzonejs:dropzonejs_eb_widget
    

    when touching this anyway, you do might want to add the core_version_requirement: ^8 || ^9 already though, one thing less to fix, and the version: VERSION is also bogus, remove.

Primsi’s picture

Status: Needs work » Needs review
FileSize
1.56 KB
20.98 KB

Addressed 1. Ignored 2. per chat :)

  • Primsi committed 1902e88 on 8.x-2.x
    Issue #3086881 by Primsi, Berdir: Add test coverage to eb_widget
    
Primsi’s picture

Version: 8.x-2.x-dev » 8.x-1.x-dev
Primsi’s picture

Rerolling.

Primsi’s picture

Um,... here it passed, but now head is failing.

Primsi’s picture

Looks like testbot ignores our drupalci?

> This build does not contain a modified drupalci.yml file. Using existing assessment stage.

  • Primsi committed b567100 on 8.x-2.x
    Issue #3086881 by Primsi: trying to fix head as per #3099984
    
Primsi’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev
FileSize
1.04 KB

Changing commands syntax.

  • Primsi committed 9670437 on 8.x-2.x
    Issue #3086881 by Primsi, Berdir, mixologic: Fix head test fails related...
Primsi’s picture

Let's retry with 8.x-1.x. now.

Primsi’s picture

Version: 8.x-2.x-dev » 8.x-1.x-dev
Status: Needs review » Needs work

Eh, of course not,... doing that on autopilot.