Problem/Motivation

At the moment build tests run with a concurrency > 30. This can cause issues with diskspace on the test bots. See #3086179-8: Fix spurious failures attempting to allocate a web server in the build tests

Proposed resolution

  • Consider limiting concurrency ala nightwatch
  • Consider not copying VCS files to the test build (or maybe make this optional)

Remaining tasks

Decide approach

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

The last submitted patch, 2: 3086308-2.patch, failed testing. View results

heddn’s picture

One item of note about git clones. Those things are all shallow clones. So they shouldn't be using all that much space when compared with a tarball download or other means of getting various versions of drupal installed in a repeatable manner.

That said, #3082230: [meta] Convert some tests to Build tests demonstrates a way to get around the shallow clone. I guess my point is, whatever we decide on, we should error on the side of less concurrency as disk space will get utilized by these build tests.

alexpott’s picture

I guess we can see that 15 passes and is the same as JS testing so let's start there. If this needs to be adjusted we can do that. But the patch shows that at the current levels the concurrency is too high.

heddn’s picture

Status: Needs review » Reviewed & tested by the community

Seems reasonable to me. We can always adjust further later on.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

  • catch committed f59792e on 9.0.x
    Issue #3086308 by alexpott, heddn: Limit concurrency of build tests
    

  • catch committed 7269453 on 8.9.x
    Issue #3086308 by alexpott, heddn: Limit concurrency of build tests
    
    (...
catch’s picture

Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.0.x, 8.9.x, and 8.8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.