We are using Paragraphs and have implemented Asymmetric Translation for our experimental widgets. This requires us to perform some processing before the file downloads are processed and the translations are applied.

We would like a new event to be added so that we may subscribe to it. I will add a patch file to this request later today and I would like to suggest that it is added as a new feature for the module.

Thanks!
Mike

CommentFileSizeAuthor
#4 interdiff-2-4.txt3.03 KBLoparev
#4 tmgmt_smartling-after_download_event-3085547-4.patch3.67 KBLoparev
#3 3085547-add-new-event-for-the-file-download-action-2.patch2.19 KBkeats76
#2 3085547-add-new-event-for-the-file-download-action.patch2.3 KBkeats76
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

keats76 created an issue. See original summary.

keats76’s picture

keats76 CreditAttribution: keats76 commented
FileSize
3085547-add-new-event-for-the-file-download-action.patch2.3 KB

This is my first attempt at a contributed patch. Hopefully, it will work properly. Thanks

keats76’s picture

keats76 CreditAttribution: keats76 commented
FileSize
3085547-add-new-event-for-the-file-download-action-2.patch2.19 KB

Path issue.

Loparev’s picture

Loparev CreditAttribution: Loparev commented
Status: Active » Needs review
FileSize
tmgmt_smartling-after_download_event-3085547-4.patch3.67 KB
interdiff-2-4.txt3.03 KB

Hi @keats76,

Thanks for the patch. I have a proposal to extract `getJob()` method into an interface and also provide a trait which provides protected property + implements constructor and `getJob` methods. Because for now seems like we have a code duplication since there is `RequestTranslationEvent` class with exactly the same contents.

  • Loparev committed 9239752 on 8.x-4.x 
    Issue #3085547 by keats76, Loparev: Add New Event For The File Download...
keats76’s picture

keats76 CreditAttribution: keats76 commented

Works for me. Thanks @Loparev!

Loparev’s picture

Loparev CreditAttribution: Loparev commented
Status: Needs review » Fixed

Released 8.x-4.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.