CommentFileSizeAuthor
#11 checklistapi-3083483-10.patch4.63 KBTravisCarden
#10 checklistapi-3083483-9.patch4.46 KBTravisCarden
#8 3083483-8.patch3.08 KBchr.fritsch
#4 3083483-4.patch3.7 KBvuil
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ilchovuchkov created an issue. See original summary.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Category: Support request » Plan
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented

$ drupal-check web/modules/checklistapi

 18/18 [============================] 100%

 ------ ----------------------------------------------------
  Line   checklistapi.drush.inc
 ------ ----------------------------------------------------
  50     Call to deprecated function drush_print().
  88     Call to deprecated function drush_get_arguments().
  99     Call to deprecated function drush_set_context().
  106    Call to deprecated function drush_get_context().
  110    Call to deprecated function drush_print().
  115    Call to deprecated function drush_print().
  116    Call to deprecated function drush_print().
  120    Call to deprecated function drush_print().
  133    Call to deprecated function drush_print().
  134    Call to deprecated function drush_print().
  151    Call to deprecated function drush_print().
 ------ ----------------------------------------------------

 ------ ----------------------------------------------------
  Line   checklistapi.install
 ------ ----------------------------------------------------
  19     Access to deprecated property $config of class Drupal\checklistapi\ChecklistapiChecklist:
         since version 8.x-1.9, to be removed in 8.x-2.0.
  19     Fetching deprecated class constant PROGRESS_CONFIG_KEY of class Drupal\checklistapi\ChecklistapiChecklist:
         since version 8.x-1.9, to be removed in 8.x-2.0.
  34     Access to deprecated property $config of class Drupal\checklistapi\ChecklistapiChecklist:
         since version 8.x-1.9, to be removed in 8.x-2.0.
  34     Fetching deprecated class constant PROGRESS_CONFIG_KEY of class Drupal\checklistapi\ChecklistapiChecklist:
         since version 8.x-1.9, to be removed in 8.x-2.0.
 ------ ----------------------------------------------------

 [ERROR] Found 15 errors
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented
Status: Active » Needs review
FileSize
3083483-4.patch3.7 KB

Add 'use strict'; in javascript file.
Fix the Javascript coding standards error.

  • vuil committed 6de48a1 on 8.x-1.x 
    Issue #3083483 by vuil: Add Javascript coding standards.
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented
Status: Needs review » Needs work
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Category: Plan » Task
Issue tags: -D9Readiness +Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs work » Needs review
FileSize
3083483-8.patch3.08 KB

Some initial work.

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden at Acquia commented

Hey, everybody. Thanks for the contributions! I just want to let you know that this is on my radar and I intend to review it. I just haven't been able to get to it yet.

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden at Acquia commented
Assigned: Unassigned » TravisCarden
FileSize
checklistapi-3083483-9.patch4.46 KB
TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden at Acquia commented
FileSize
checklistapi-3083483-10.patch4.63 KB

  • TravisCarden committed d57d759 on 8.x-1.x 
    Issue #3083483 by TravisCarden, vuil, chr.fritsch: Test for Drupal 9...
TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden at Acquia commented
Assigned: TravisCarden » Unassigned
Status: Needs review » Fixed
Issue tags: -Drupal 9 compatibility

All fixed. Thanks, everyone! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.