Fire intended events when invoking a specific transition

For hours I have been renaming my events trying to figure out why my second transition event would not fire. Thanks for reporting and providing a solution.

+++ b/src/Plugin/Field/FieldType/StateItem.php
@@ -342,7 +350,9 @@ class StateItem extends FieldItemBase implements StateItemInterface, OptionsProv
+    $transition = $this->appliedTransition
+      ? $this->appliedTransition
+      : $workflow->findTransition($this->originalValue, $this->value);

Could be replaced with a Null coalescing operator:

  $transition = $this->appliedTransition ?? $workflow->findTransition($this->originalValue, $this->value);

Renamed appliedTransition to transitionToApply, and used the Null coalescing operator.

Also added a comment so we know why this is there :).

Better with the patch no? :p

Should we add or update a test for this?

If there are 2 transitions with the same 'from' and 'to' states, the code would previously always select the first one.
Triggering the second transition and then checking it should fail for the current code and pass with the patched code.

I guess it would look something like this?

Oh, forgot to add the newly created configurations :(

Great, the test works (test only patch selected completed1 instead of completed2). It only failed on a stupid copy/paste error.
No test_only anymore as that point is already proven in #8.

Thanks everyone! Committed!

@bradjones1: Sure, but I'd love to get #3051503: Implement a confirmation form before the transition in as well in the next release.

As soon as this is done, I'll tag a release.

I believe this introduced a regression as reported in #2912849: Require confirmation for state transitions.

Before applying the transition... We're not checking whether it is allowed... As a consequence, "canceled" shipments are marked as "shipped"... although the previous behavior was changing the state, but then skipping the transition.

Hm.... With the previous code, the state would still be changed, it's just the event that wouldn't be fired (because no transition would be found by dispatchTransitionEvent())... So unsure what to do here...

Either applyTransition() should first check if the transition is allowed... Or code calling it should check that the transition is allowed...

I think that relates to #3052752: When calling applyTransition directly (as commerce does) the guards are never invoked?
Both options have been proposed there.

Setting the status back to "fixed" as I believe the problem is not coming from this code but code applying transition without checking if the transition is allowed before.

Also, if a fix needs to implemented in State machine itself, it should happen in #3052752: When calling applyTransition directly (as commerce does) the guards are never invoked.