Closed (fixed)
Project:
Salesforce Suite
Version:
8.x-3.x-dev
Component:
salesforce_mapping.module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
20 Sep 2019 at 12:08 UTC
Updated:
17 Jan 2020 at 19:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
aron novakLikely there's a nicer solution, User entity is likely not the only possible exception where the code should not only get getBaseFieldDefinitions
Comment #3
aaronbaumanLooks good, thanks for the patch.
We can make this more robust: instead of hardcoding "user", let's use this approach for any entity type with only one bundle.
Comment #4
aron novakHow about this one?
According to https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21... ,
" outer array is keyed by the bundle name, or the entity type name if the entity does not have bundles", so as an edge case, we still have the "user" as we had previously, from the entity name.
Comment #5
aron novakThe previous patch had an unused variable.
Comment #6
aron novakComment #8
aaronbaumanOK, finally fixed the unrelated test failure and committed.
Thanks for the patch