Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I recently started to experience issues with entities embedding through the ckeditor
. The initial Select content to embed
window pops up but after i press next nothing happens. There is no errors in the console. I can see the ajax call:
http://local.project.test/entity-embed/dialog/full_html/test?_wrapper_format=drupal_ajax&ajax_form=1&_wrapper_format=drupal_ajax
It returns a 200 but nothing happens.
Thanks
Comment | File | Size | Author |
---|---|---|---|
#5 | 3081825.patch | 536 bytes | doidd |
|
Issue fork entity_embed-3081825
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
jedgar1mx CreditAttribution: jedgar1mx commentedComment #3
jedgar1mx CreditAttribution: jedgar1mx commentedThis issue seems to be related to different module.
Comment #4
jedgar1mx CreditAttribution: jedgar1mx commentedComment #5
doidd CreditAttribution: doidd commentedI have the same problem. This issue come after commit fix issue #2844822 with commit df13709. This commit override method getLibraries but not include library embed/embed so we missing library and embed entity not display. I create a patch to fix it.
Comment #6
jedgar1mx CreditAttribution: jedgar1mx commentedThanks @doidd, i will test the patch as well and report back.
Comment #7
geek-merlin> This commit override method getLibraries but not include library embed/embed so we missing library
I did not manually test this but can confirm code-wise that the other commit introduces said bug that this patch trivially fixes.
Comment #8
Dave ReidSo the embed/embed library already defines dependencies on jquery and drupal.ajax (and hence drupal), so I think we can just get rid of the getLibraries() method entirely and only rely on the parent method.
Comment #11
Dave ReidMerged the above into 8.x-1.x.