I recently started to experience issues with entities embedding through the ckeditor. The initial Select content to embed window pops up but after i press next nothing happens. There is no errors in the console. I can see the ajax call:

http://local.project.test/entity-embed/dialog/full_html/test?_wrapper_format=drupal_ajax&ajax_form=1&_wrapper_format=drupal_ajax

It returns a 200 but nothing happens.

Thanks

CommentFileSizeAuthor
#5 3081825.patch536 bytesdoidd
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jedgar1mx created an issue. See original summary.

jedgar1mx’s picture

jedgar1mx’s picture

This issue seems to be related to different module.

jedgar1mx’s picture

Status: Active » Closed (duplicate)
doidd’s picture

Status: Closed (duplicate) » Needs review
FileSize
536 bytes

I have the same problem. This issue come after commit fix issue #2844822 with commit df13709. This commit override method getLibraries but not include library embed/embed so we missing library and embed entity not display. I create a patch to fix it.

jedgar1mx’s picture

Thanks @doidd, i will test the patch as well and report back.

geek-merlin’s picture

Version: 8.x-1.0 » 8.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

> This commit override method getLibraries but not include library embed/embed so we missing library

I did not manually test this but can confirm code-wise that the other commit introduces said bug that this patch trivially fixes.

Dave Reid’s picture

So the embed/embed library already defines dependencies on jquery and drupal.ajax (and hence drupal), so I think we can just get rid of the getLibraries() method entirely and only rely on the parent method.

  • Dave Reid committed cc96740 on 8.x-1.x
    Issue #3081825 by Dave Reid, doidd: Fixed CKEditor plugin was overriding...
Dave Reid’s picture

Status: Reviewed & tested by the community » Fixed

Merged the above into 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.