Add a new recipe to Umami demo for homemade hummus

Thank you @kjay, it looks great!

I'm thinking that we should have the patch AND the Spanish translation in this issue.
Start with patch in English, we'll get volunteers to help translating it to Spanish, and then we'll update the patch to include both languages.

Thank you @kjay, I tested your patch and it works great.
When running git apply -v umami-recipe-hummus-3080692-3.patch I received a few error messages.
Could this be because of the image file which is part of the patch?

Checking patch core/profiles/demo_umami/modules/demo_umami_content/default_content/images/hummus-umami.jpg...
Checking patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/node/recipe.csv...
Checking patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/recipe_instructions/hummus-umami.html...
Applied patch core/profiles/demo_umami/modules/demo_umami_content/default_content/images/hummus-umami.jpg cleanly.
Applied patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/node/recipe.csv cleanly.
Applied patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/recipe_instructions/hummus-umami.html cleanly.
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.

I created a google-doc to manage the translation to Spanish, and when the translations gets approved we'll create a new patch to include both English and Spanish.
https://docs.google.com/spreadsheets/d/13pRJx7RzQdf3wlVk9ZTyCaSxj9nuhp5c...

I attached the screenshot of the recipe after I applied patch #3

Assigning to myself as its not updated since last 8 months. @kjay

@nitesh624 thank you for working on this.
Can you please add interdiff file that will show the changes from the previous patch?

hi @shaal thanks for quick reply. I couldn't create interdiff betweeb #3 and #11 . Can you please help me?
getting below error when running command

Perhaps your patch included a reroll? that would usually be the reason interdiff wouldn't work.

In those cases I use regular diff between the 2 patches, here's an explanation about that -
https://www.drupal.org/documentation/git/interdiff#reroll

@shaal this file i got after running diff -u umami-recipe-hummus-3080692-3.patch umami-recipe-hummus-3080692-11.patch > reroll_diff_3-11.txt

nitesh.kumar@pg01g1ud:/var/www/html/D-9.1.x-umami$ git apply --check patches/umami/umami-recipe-hummus-3080692-3.patch
error: patch failed: core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/node/recipe.csv:8
error: core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/node/recipe.csv: patch does not apply

Verified and tested by applying the patch #11.

Getting warning while applying the patch.

Please find the below observations:
The text highlighted in yellow in this doc link "https://docs.google.com/spreadsheets/d/1sr3f6u-m50OpEQn1C4_bxDPQvEvPrKKj..." is not there in the English and Spanish Recipe Content Type.

Steps to test -
1. Go to admin site.
2. Go to admin/content.
3. Filter out the Recipe content type.
4. Verify the content for English(Fresh and tasty homemade hummus) and Spanish(Hummus fresco y sabroso casero) Recipe.

After Patch English Recipe-

After Patch Spanish Recipe-

I'm getting the same errors when applying the patch from #11

$ git apply -v ../_patches/umami-recipe-hummus-3080692-11.patch 
../_patches/umami-recipe-hummus-3080692-11.patch:40: trailing whitespace.
"T?o6ڋHTɖ(E<?W??? 
../_patches/umami-recipe-hummus-3080692-11.patch:102: trailing whitespace.
???????P??E?_)"?d????&?ߡ?"?+;?X?Kȅ?,??e?q??ξƬ??n??%dc?L???b?D?>???ݗ?F]?T)?%??cӼ'E?vv??"8\W'???6Wf?%?????H?(Ң??I"?1?F?[k????ԍR4???2oq%?ɿ???\?|?o?+P?pv1?YՎ4??U?O??i??B?#???(???hs?v??X??^K?e??p?>ɾ?"??i??=???"u??x?x??!?tdKI?6?F?d??ѫ>?^?J????m?#?J??^{??"(??H)!??C?7~K?6"Ŗ??K?zBeY-&??
../_patches/umami-recipe-hummus-3080692-11.patch:168: trailing whitespace.
?Q??ZSB홡!?/??ܾ?
../_patches/umami-recipe-hummus-3080692-11.patch:248: trailing whitespace.
7?
../_patches/umami-recipe-hummus-3080692-11.patch:273: trailing whitespace.
?g_,????????镰f;
                ?;h?{?a?Q??y?PiW???eТ??㉚??3??)?s?Sm9* 
Checking patch core/profiles/demo_umami/modules/demo_umami_content/default_content/images/hummus-umami.jpg...
Checking patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/media/image.csv...
Checking patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/node/recipe.csv...
Checking patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/recipe_instructions/hummus-umami.html...
Checking patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/node/recipe.csv...
Checking patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/recipe_instructions/hummus-umami.html...
Applied patch core/profiles/demo_umami/modules/demo_umami_content/default_content/images/hummus-umami.jpg cleanly.
Applied patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/media/image.csv cleanly.
Applied patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/node/recipe.csv cleanly.
Applied patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/en/recipe_instructions/hummus-umami.html cleanly.
Applied patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/node/recipe.csv cleanly.
Applied patch core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/recipe_instructions/hummus-umami.html cleanly.
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.

I have a feeling those whitespace errors are coming from the images that are embedded inside the patch. If that's the case, I think we can ignore them.

Most of the text that is missing in the English/Spanish reported by @priyanka.sahni is in the patch as far as I can see from doing a "search and find" in my text editor. The only one not there is the Spanish translation of the image alt text. If someone can add that, I can test again.

Adding Europe2020 tag.

Uploading patch and interdiff.

Hi @vulcanr

Thanks for this patch. It looks like there you need to put your alt text into a quote since there is a comma in it. Without this, the import thinks everything after the comma is the name of the author (and since we don't have an author of that name, the translation is not created).

Adding quotation on the string, so commas can be displayed in the string

Changing tag

Patch applies fine, tests have passed. Thanks for working on this @vulcanr @priyanka.sahni @nitesh624 @shaal @kjay

Let's mark it RTBC

There are some CI failures on the most recent patch.

Hi @lauriii

The failure seems to be a word "Za'tar" that the CI doesn't know about. Is that a false positive?

The only other thing I can think of here is that the jpg files are causing a whitespace issue, but again that would be a false positive.

@vulcanr

It looks like Za'atar is not in the allowed words in our dictionary at /core/misc/cspell/dictionary.txt.

Wanna create a new patch and interdiff adding that word to the dictionary and I can test it again then?

Added Za'atar to /core/misc/cspell/dictionary.txt.

Just tested #33. Woks as expected.

Marking as RTBC - Sorry for the duplicated comment.

Moving back to Needs work per the feedback.

Working on this, will get back with update by tomorrow.

Looks like @ckrina's comment that "400g tin chickpeas in water" is definitely not Spanish has not been fixed.

Raised MR against 10 branch. And addressed unresolved #1301 MR feeback points.

MR 3837 appears to address the "400g tin chickpeas in water" into spanish.

We need to update core/profiles/demo_umami/modules/demo_umami_content/default_content/LICENCE.txt with the appropriate license for the image. However, I'm not sure what's the process for that since based on the issue summary, I'm not certain if the author of the image has a Drupal.org account.

Addressed #52 feedback point. Tried to locate the (Anna Christoforou) author's Drupal org account, but not able to locate the user(Anna Christoforou). For consistency, follow the contents of the license text file and mention the user with the user's image.

Thanks very much @Rassoni

Discussed with @catch about this issue since it involves relicensing pictures from a person who is not involved on the issue. We agreed that to be able to proceed here, we need a written statement from the author of the picture/recipe that we can ship the picture under CC BY-SA 4.0.