The "show reset link" functionality works properly with the query_string url processor, but not with the pretty paths one.

CommentFileSizeAuthor
#3 show_reset_link_when_pretty_path_is_active-3079451-3.patch543 bytesmonymirza
#2 show_reset_link_do_not_work_when_pretty_path_is_active-3079451-2.patch543 bytesnanak
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nanak created an issue. See original summary.

nanak’s picture

nanak
Primary language French
Location Sarlat-la-Canéda
CreditAttribution: nanak as a volunteer and at Dropsolid commented
Status: Active » Needs review
FileSize
show_reset_link_do_not_work_when_pretty_path_is_active-3079451-2.patch543 bytes

When pretty path is on, the facets_query route parameter is not empty, and the url of the show reset link is the same than the current page.
Emptying this parameter when the url is built seems to fix the issue.

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
CreditAttribution: monymirza as a volunteer commented
FileSize
show_reset_link_when_pretty_path_is_active-3079451-3.patch543 bytes

re-roll dev.

Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl as a volunteer and at Cheppers commented
Status: Needs review » Reviewed & tested by the community

@nanak thanks for the patch and @monymirza for rerolling. Now tested, patch solves the problem described. Marking as RTBC.

mellowtothemax’s picture

mellowtothemax CreditAttribution: mellowtothemax commented

Patch works for me too

borisson_ credited andreasderijcke.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented

Duplicate of #3154859, ensuring that andreas gets credit here as well.

  • borisson_ committed 9bd8576 on 8.x-1.x authored by monymirza 
    Issue #3079451 by nanak, monymirza, andreasderijcke: "Show reset link"...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.