SqlContentEntityStorage now expects $entity_type_bundle_info and $entity_type_manager as the last two parameters, and without them we get these messages while testing:

  36x: Calling ContentEntityStorageBase::__construct() with the $entity_type_bundle_info argument is supported in drupal:8.7.0 and will be required before drupal:9.0.0. See https://www.drupal.org/node/2549139.
    6x in AddressBookTest::testHasUi from Drupal\Tests\commerce_order\Kernel
    6x in AddressBookTest::testLoadProfileTypes from Drupal\Tests\commerce_order\Kernel
    6x in AddressBookTest::testLoadProfiles from Drupal\Tests\commerce_order\Kernel
    6x in AddressBookTest::testNeedsCopy from Drupal\Tests\commerce_order\Kernel
    6x in AddressBookTest::testCopyMultiple from Drupal\Tests\commerce_order\Kernel
    6x in AddressBookTest::testCopySingle from Drupal\Tests\commerce_order\Kernel

  36x: Calling SqlContentEntityStorage::__construct() with the $entity_type_manager argument is supported in drupal:8.7.0 and will be required before drupal:9.0.0. See https://www.drupal.org/node/2549139.
    6x in AddressBookTest::testHasUi from Drupal\Tests\commerce_order\Kernel
    6x in AddressBookTest::testLoadProfileTypes from Drupal\Tests\commerce_order\Kernel
    6x in AddressBookTest::testLoadProfiles from Drupal\Tests\commerce_order\Kernel
    6x in AddressBookTest::testNeedsCopy from Drupal\Tests\commerce_order\Kernel
    6x in AddressBookTest::testCopyMultiple from Drupal\Tests\commerce_order\Kernel
    6x in AddressBookTest::testCopySingle from Drupal\Tests\commerce_order\Kernel
CommentFileSizeAuthor
#2 3078769-2-storage-constructors.patch20.56 KBbojanz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Active » Needs review
FileSize
3078769-2-storage-constructors.patch20.56 KB

The constructors have gotten out of hand. We really need to move all custom loading logic to our own repositories.

  • bojanz committed 80a1abf on 8.x-2.x 
    Issue #3078769 by bojanz: CommerceContentEntityStorage needs to pass...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.