Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drumm created an issue. See original summary.

idebr’s picture

There are two more mentions in the repository that mention cgit.drupalcode.org. Perhaps we can update these as well?

  1. // List of unicode-encoded characters that were allowed in URLs,
          // according to link module in Drupal 7. Every character between ¿
          // and ÿ (except × × and ÷ ÷) with the addition of
          // Œ, œ and Ÿ.
          // @see http://cgit.drupalcode.org/link/tree/link.module?h=7.x-1.5-beta2#n1382
    

    \Drupal\link\Plugin\migrate\process\FieldLink::canonicalizeUri()

  2. Previous versions of drupal-scaffold (see community project,
    [drupal-composer/drupal-scaffold](https://github.com/drupal-composer/drupal-project))
    downloaded each scaffold file directly from its distribution server (e.g.
    `https://cgit.drupalcode.org`) to the desired destination directory.
    

    ./composer/Plugin/Scaffold/README.md

shubham.prakash’s picture

This patch should fix the issue.

idebr’s picture

Status: Needs review » Needs work

@shubham.prakash Thanks for providing a new patch! Can you add an interdiff next time to make it easier to review the patch? See https://www.drupal.org/documentation/git/interdiff for more information

+++ b/core/modules/link/src/Plugin/migrate/process/FieldLink.php
@@ -73,7 +73,7 @@ protected function canonicalizeUri($uri) {
-      // @see http://cgit.drupalcode.org/link/tree/link.module?h=7.x-1.5-beta2#n1382
+      // @see https://git.drupalcode.org/project/link/blob/7.x-1.5-beta2/link.module#n1382

Gitlab uses a different fragment structure to reference line numbers:

cgit: #n1382
Gitlab: #L1382

This fragment should be updated to keep the line reference intact.

shubham.prakash’s picture

Assigned: Unassigned » shubham.prakash
shubham.prakash’s picture

Thanks for the review. This patch should fix the issue.

shubham.prakash’s picture

Status: Needs work » Needs review
drumm’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • catch committed 188c37b on 8.8.x
    Issue #3076585 by shubham.prakash, drumm, idebr: Update browse Git repo...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed 188c37b and pushed to 8.8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.