Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Since Drupal.org’s migration to GitLab, http://cgit.drupalcode.org/drupal is now https://git.drupalcode.org/project/drupal
Comment | File | Size | Author |
---|---|---|---|
#6 | 3076585-5-interdiff.txt | 955 bytes | shubham.prakash |
#6 | 3076585-5.patch | 13.2 KB | shubham.prakash |
#3 | 3076585-3.patch | 13.2 KB | shubham.prakash |
component-readme-links.patch | 11.41 KB | drumm | |
Comments
Comment #2
idebr CreditAttribution: idebr at ezCompany commentedThere are two more mentions in the repository that mention cgit.drupalcode.org. Perhaps we can update these as well?
\Drupal\link\Plugin\migrate\process\FieldLink::canonicalizeUri()
./composer/Plugin/Scaffold/README.md
Comment #3
shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commentedThis patch should fix the issue.
Comment #4
idebr CreditAttribution: idebr at ezCompany commented@shubham.prakash Thanks for providing a new patch! Can you add an interdiff next time to make it easier to review the patch? See https://www.drupal.org/documentation/git/interdiff for more information
Gitlab uses a different fragment structure to reference line numbers:
cgit: #n1382
Gitlab: #L1382
This fragment should be updated to keep the line reference intact.
Comment #5
shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commentedComment #6
shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commentedThanks for the review. This patch should fix the issue.
Comment #7
shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commentedComment #8
drummLooks good to me.
Comment #10
catchCommitted 188c37b and pushed to 8.8.x. Thanks!