Problem/Motivation

The Scaffold plugin currently resides in core/lib/Drupal/Component, where it is subtree-split out into its own component. In this configuration, when used by a Composer-based Drupal site, the code for the scaffold component would exist in the project in two locations: inside vendor, where it is actually run from, and also inside core/lib/Drupal/Component, its unused source location.

Proposed resolution

To avoid this unnecessary duplication of code, it was decided to relocate the Composer plugins out of the core directory and instead put them in composer/Plugin, so that they do not become part of the drupal/core subtree split.

This location is already being used in the most recent patch in #3057094: Add Composer vendor/ hardening plugin to core.

Remaining tasks

None.

Follow-on Tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

n/a

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greg.1.anderson created an issue. See original summary.

greg.1.anderson’s picture

Patch with a failing test, to ensure that relocated tests are still running.

greg.1.anderson’s picture

Status: Active » Needs review

Set status to run the tests.

Status: Needs review » Needs work

The last submitted patch, 2: 3076234-2.patch, failed testing. View results

greg.1.anderson’s picture

Status: Needs work » Needs review
FileSize
711 bytes
80.94 KB

Same thing, but without the failing test.

Mile23’s picture

Status: Needs review » Reviewed & tested by the community

Checked that all the files were moved, and got a passing test run from:

$ composer dumpautoload
$ ./vendor/bin/phpunit -c core/ --group Scaffold

RTBC, man.

larowlan’s picture

Status: Reviewed & tested by the community » Fixed

I tested that files in this folder could not be accessed via the browser, and confirmed they were access denied.

Committed 3a4092e and pushed to 8.8.x. Thanks!

  • larowlan committed 3a4092e on 8.8.x
    Issue #3076234 by greg.1.anderson, Mile23: Relocate Scaffold plugin...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.