Both getHtml5DateFormat and getHtml5TimeFormatin class Drupal\Core\Datetime\Element\Datetime have Type string for input parameter $element, this should be array.

CommentFileSizeAuthor
#2 incorrect_type_phpdoc_getHtml5DateFormat_getHtml5TimeFormat-3075661-2.patch848 bytesSpokje
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Spokje created an issue. See original summary.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje at Annertech for Society of Actuaries in Ireland commented
FileSize
incorrect_type_phpdoc_getHtml5DateFormat_getHtml5TimeFormat-3075661-2.patch848 bytes

Attached patch fixes the wrongly typed input variable $element in both functions.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje at Annertech for Society of Actuaries in Ireland commented
Assigned: Spokje » Unassigned
Status: Active » Needs review
idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Needs review » Reviewed & tested by the community

Patch in #2 correctly fixes the docblocks, thanks @Spokje

  • larowlan committed 1b07788 on 8.8.x 
    Issue #3075661 by Spokje: getHtml5DateFormat and getHtml5TimeFormat in...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

  • larowlan committed 32b6f79 on 8.7.x 
    Issue #3075661 by Spokje: getHtml5DateFormat and getHtml5TimeFormat in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.