Problem/Motivation

#2821077: PATCHing entities validates the entire entity, also unmodified fields, so unmodified fields can throw validation errors was solved.

But UserTest::testPatchDxForSecuritySensitiveBaseFields() still contains:

// @todo Remove the array_diff_key() call in https://www.drupal.org/node/2821077

Proposed resolution

Address the todo.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#2 3075422-2.patch2.75 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Assigned: Unassigned » gabesullice
Status: Active » Needs review
FileSize
3075422-2.patch2.75 KB
gabesullice’s picture

gabesullice
Primary language English
CreditAttribution: gabesullice at Acquia commented
Assigned: gabesullice » Unassigned
Status: Needs review » Reviewed & tested by the community

Thanks @Wim Leers! LGTM

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed 50a700f and pushed to 8.8.x. Thanks!

  • larowlan committed 50a700f on 8.8.x 
    Issue #3075422 by Wim Leers: Follow-up for #2821077: address forgotten @...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.