Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When clicking the "add a comment" button on a post, you a redirected to a page with title "Reply to comment". It doesn't matter if you are the first to comment on the post, let alone that you are not at all replying to another comment (you are replying to the post itself).
"Reply to comment" is just not fit for al the cases it is used for...
Comment | File | Size | Author |
---|---|---|---|
#6 | 307422-make-comment-text-consistent-rev2.patch | 1.57 KB | brianV |
#1 | 307422-make-comment-text-consistent.patch | 2.68 KB | brianV |
Comments
Comment #1
brianV CreditAttribution: brianV commentedIn 7.x, this discrepancy still exists.
The default comment link is titles 'Add new comment', while the comment form page is titled 'Reply to comment' and the actual comment form is titled 'Reply'
These three elements need to be made consistent with one another.
I would propose 'Add a new comment' as a good replacement for all three. I've attached a patch to implement that; of course, alternate suggestions are encouraged.
Also tagging for Usablity.
Comment #2
brianV CreditAttribution: brianV commentedComment #3
catchLooks good to me, also aligns well with 'Add new content' - is there a problem using 'Add new comment' everything though and skipping the 'a'?
Comment #4
brianV CreditAttribution: brianV commentedNo problem. Just 'Add a new comment' makes better grammatical sense then 'Add new comment'.
If the concensus is that it should be changed, I will.
Comment #5
Dries CreditAttribution: Dries commented"Add a new comment" doesn't flow as fast as "Add new comment". Can we standardize on "Add new comment" first, and then debate the "a" as a follow-up -- can be done in the same issue.
Comment #6
brianV CreditAttribution: brianV commentedNew patch with 'Add new comment' across the board.
Comment #7
Dries CreditAttribution: Dries commentedCommitted this patch. Let's keep discussing the 'a' now.
Comment #8
brianV CreditAttribution: brianV commentedI don't know how much discussion is needed, since there isn't a 'right' way and a 'wrong' way.
'Add new comment' does indeed flow better as you pointed out. 'Add a new comment' seems a little more 'correct'.
However, it's not a big enough deal to make it worth patching. The purpose is clearly communicated in both strings, so I am happy enough just leaving it as it is.
Comment #9
catchSince BrianV is happy with the change as is I'm going to mark this to fixed.
Comment #10
Shai CreditAttribution: Shai commentedWoot, woot! I filed this issue in Nov. '07 (http://drupal.org/node/189659) and a discussion went back and forth with different possibilities that didn't coalesce before code froze for 6.... 42 posts in all. But here, just 9 posts and three days, and voila -- a commit for 7! Sometimes the world is just ready for something, no hassle necessary :)
Thanks for all the great work brianV, Dries, and catch.
Shai