We added a postgres 9.5 container yesterday, and there is one fail, which appears to be a new reserved keyword.
https://www.drupal.org/pift-ci-job/1374620

Lets add that keyword and see if we've got passing postgres 9.5 tests.

CommentFileSizeAuthor
#5 3074157_5.patch986 bytesMixologic
#2 3074157_2.patch873 bytesMixologic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mixologic created an issue. See original summary.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
FileSize
3074157_2.patch873 bytes
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Status: Active » Needs review
Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at ezCompany commented
Status: Needs review » Reviewed & tested by the community

Was red, is now green.

Seems like the existing list was kept close to the 80 character limit and this is sticking out a bit further now, do we care?

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
FileSize
3074157_5.patch986 bytes

Good catch, Simple to get that right.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Status: Reviewed & tested by the community » Needs review
daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

for me this is RTBC.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
CreditAttribution: mradcliffe at Kosada commented

This looks good. Thank you for the patch, @Mixologic.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed 6d2e353 and pushed to 8.8.x. Thanks!

  • larowlan committed 6d2e353 on 8.8.x 
    Issue #3074157 by Mixologic: Escape "tablesample" for postgres 9.5...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.