Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
According to coding standard checker, direct dsm() call is discouraged.
- dumper (as service) should be injected via setter, other constructor arguments cleaned as it changes
- form depends only on file storage (not entity type manager)
- forms should use request object via buildForm()
instead of request stack
Comment | File | Size | Author |
---|---|---|---|
#6 | interdiff.txt | 1.37 KB | andypost |
#6 | 3072425-6.patch | 7.38 KB | andypost |
|
Comments
Comment #2
dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commentedComment #3
EgorSolocnhenko CreditAttribution: EgorSolocnhenko as a volunteer commentedThis issue is fixed here https://www.drupal.org/project/examples/issues/3072438
Comment #4
andypostThis change require change of constructor to show proper usage of DI
I will repurpose #3072438: file_example fix verbose() usage tests to verbose fix
Comment #6
andypostNice to see that we have test coverage here, fixed + minor code-style clean-ups
Comment #7
goodboyI checked everything and did not find errors.
+1 to RTBC
Comment #9
valthebaldCommitted to 8.x-1.x, thank you!
Comment #10
andypost