Problem/Motivation

When the field enhancer depends on something external to the entity for example configuration, it's cachability meta-data should be able to bubble during the normalization process.

As it is on 8.x-3.4 this is not possible to define, leading to sometimes frustrated clients and the need to whipe the whole page / render / cdn cache to reflect a simple config change.

Proposed resolution

If this was resolved in future versions of the module - point me there.

Otherwise this is a valid bug and as I see it, we should either extend the use of the $context parameter or change the API.

Remaining tasks

TBD.

User interface changes

TBD.

API changes

TBD.

Data model changes

TBD.

Release notes snippet

TBD.

Original report by [username]

TBD.

Issue fork jsonapi_extras-3071310

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ndobromirov created an issue. See original summary.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

@ndobromirov I am very interested on this. Did you end up writing a patch for your project?

ndobromirov’s picture

ndobromirov CreditAttribution: ndobromirov at FFW commented

not yet

ndobromirov’s picture

ndobromirov CreditAttribution: ndobromirov at FFW commented

This was mainly because of lack of time and somewhat lack of direction to dive in.

My initial idea was to have the context argument have a special key in there - related to the cacheability.
But I think it's better to have an explocit interface for that... Maybe a new (or some existing) interface to be implemented per enhancer and the using code to do feature detection based on the interface and boubble the cachability metadata...

No idea... Need to get into it, but this will be not sooner than 2-3 weeks from now :(

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

All that sounds good!

Need to get into it, but this will be not sooner than 2-3 weeks from now

Just knowing it's still on your radar is good enough for me!

bbrala’s picture

bbrala
Location Netherlands
CreditAttribution: bbrala at SWIS commented

Hi @ndobromirov, been a while, you still want to get this going?

bbrala’s picture

bbrala
Location Netherlands
CreditAttribution: bbrala at SWIS commented

Another year later, still no update unfortunately. Any chance you can still make this happen?

bradjones1’s picture

bradjones1
Primary language English
CreditAttribution: bradjones1 as a volunteer commented
Assigned: Unassigned » bradjones1

I need this and I'm doing it!

bradjones1 opened merge request !5

bradjones1’s picture

bradjones1
Primary language English
CreditAttribution: bradjones1 as a volunteer commented
Assigned: bradjones1 » Unassigned
Status: Active » Needs review
bbrala’s picture

bbrala
Location Netherlands
CreditAttribution: bbrala at SWIS commented
Version: 8.x-3.4 » 8.x-3.19
Status: Needs review » Fixed

Awesome! I've tested locally, good to get this in, well done :)

  • bbrala committed 713fc5d on 8.x-3.x authored by bradjones1 
    Issue #3071310 by bradjones1, ndobromirov, bbrala, e0ipso: Field...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.