Problem/Motivation

In #3053199: Add SHA256SUMS file of all files, we have live SHA sums. Let's make the necessary modifications to make this module work with those URLs.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#32 3071193-32.patch20.87 KBheddn
#32 interdiff_31-32.txt806 bytesheddn
#31 3071193-31.patch20.8 KBheddn
#31 interdiff_30-31.txt1.09 KBheddn
#30 3071193-30.patch20.75 KBheddn
#30 interdiff_29-30.txt5.29 KBheddn
#29 3071193-29.patch19.44 KBheddn
#28 interdiff-27-28.txt2.96 KBheddn
#28 3071193-28.patch19.94 KBheddn
#27 interdiff_25-27.txt7.45 KBheddn
#27 3071193-27.patch19.94 KBheddn
#25 interdiff_23-25.txt14.78 KBheddn
#25 3071193-25.patch19.04 KBheddn
#23 interdiff_19-23.txt1.83 KBheddn
#23 3071193-23.patch5.88 KBheddn
#21 3071193-19.patch5.28 KBheddn
#20 3071193-19.patch5.28 KBheddn
#19 3071193-19.patch5.28 KBheddn
#15 3071193-15.patch20.19 KBheddn
#15 interdiff_13.15.txt1019 bytesheddn
#13 3071193-12.patch19.54 KBheddn
#12 interdiff_9-12.txt2.36 KBheddn
#12 interdiff_9-12.txt2.36 KBheddn
#9 interdiff_7-9.txt1.87 KBheddn
#9 3071193-9.patch17.64 KBheddn
#7 3071193-7.patch17.81 KBheddn
#7 interdiff_6-7.txt2.41 KBheddn
#6 3071193-6.patch17.58 KBheddn
#6 interdiff_4-6.txt4.83 KBheddn
#4 3071193-4.patch14 KBheddn
#4 interdiff_3-4.txt2.08 KBheddn
#3 3071193-3.patch13.93 KBheddn
#3 interdiff_2-3.patch11.81 KBheddn
#2 3071193.patch2.7 KBheddn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Status: Active » Needs review
FileSize
3071193.patch2.7 KB

There's a few more things that need fixing, but this get's us started. The nice thing is that the sha sums provided from #3053199: Add SHA256SUMS file of all files just work.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
interdiff_2-3.patch11.81 KB
3071193-3.patch13.93 KB

This fixes up a few more things in manual testing. Let's see how automated tests fare.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
interdiff_3-4.txt2.08 KB
3071193-4.patch14 KB

phpcs

Status: Needs review » Needs work

The last submitted patch, 4: 3071193-4.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Needs review
FileSize
interdiff_4-6.txt4.83 KB
3071193-6.patch17.58 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
interdiff_6-7.txt2.41 KB
3071193-7.patch17.81 KB

Status: Needs review » Needs work

The last submitted patch, 7: 3071193-7.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3071193-9.patch17.64 KB
interdiff_7-9.txt1.87 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Needs review
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Needs work

One other thing we need now is a test for a contrib project. Setting to NW for that. Since apart from the minor refactoring of how we are getting the info file details, that is the area that caused manual testing to fail.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Needs review
FileSize
interdiff_9-12.txt2.36 KB
interdiff_9-12.txt2.36 KB

And now we have tests.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3071193-12.patch19.54 KB
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented 
+++ b/src/ProjectInfoTrait.php
@@ -9,21 +9,65 @@ use PackageVersions\Versions;
+    if (isset($this->{$extension_type})) {

I might be missing something but I can't see anywhere in the patch or the current code where $this->{$extension_type} gets set or where it's defined as a property. Didn't pick up anything major in the review.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
interdiff_13.15.txt1019 bytes
3071193-15.patch20.19 KB

Good catch in #14. This should fix that.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Reviewed & tested by the community

We're going to say RTBC.

  • heddn committed 0994c72 on 8.x-1.x 
    Issue #3071193 by heddn, catch: Use live SHA512SUMS
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Active

Needs backport now.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Status: Active » Needs review
FileSize
3071193-19.patch5.28 KB

Here's the first part of using slightly patched version of drupal/php-signify.

This patch also utilizes https://github.com/drupal/php-signify/pull/5. Tests pass locally. Will fail on do.o.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
FileSize
3071193-19.patch5.28 KB

It will decidedly break. Wrong branch. W/ the signify work, D8 changed and patch in #19 was against 8.x.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3071193-19.patch5.28 KB

Status: Needs review » Needs work

The last submitted patch, 21: 3071193-19.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3071193-23.patch5.88 KB
interdiff_19-23.txt1.83 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Needs review
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3071193-25.patch19.04 KB
interdiff_23-25.txt14.78 KB

This will fail for several reasons, including the build test type doesn't exist yet and even if it did, it is still failing on local builds. But it is the latest thinking.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Title: Use live SHA512SUMS » Use live SHA256SUMS
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Needs work
FileSize
3071193-27.patch19.94 KB
interdiff_25-27.txt7.45 KB

This is a quick and dirty fix of tests for core. I didn't test contrib. It depends on local changes to drupal/php-signify and drupal core for the new build test type, so it isn't particularly help to run this on the testbot.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
3071193-28.patch19.94 KB
interdiff-27-28.txt2.96 KB

Needed changes for drupal/php-signify are in. And now the tests pass for core and contrib (when tested w/ the core patch).

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Needs review
FileSize
3071193-29.patch19.44 KB

Re-roll of #28 now that things upstream have landed.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
interdiff_29-30.txt5.29 KB
3071193-30.patch20.75 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
interdiff_30-31.txt1.09 KB
3071193-31.patch20.8 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
interdiff_31-32.txt806 bytes
3071193-32.patch20.87 KB

  • heddn committed 4a7ed90 on 8.x-1.x 
    Issue #3071193 by heddn, catch: Use live SHA256SUMS
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting for Drupal Association, European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Fixed

This is blocking several follow-up things, so going to commit this. Ideally this will be reviewed more completely at a later point. Besides expanded testing, the biggest changes here are simply wiring up to use php-signify.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.