Problem/Motivation

While working on adding migration states to the Commerce Migrate Module I discovered an error in the validation test. Turns out when the fixture is not loaded none of the derived migrations are created. And without all the migrations created the test isn't checking the complete set of discoverable migrations. That needs to be changed.

In addition, we should make sure that all the migrations listed in #2208401: [META] Remaining multilingual migration paths and #2456259: [META] Drupal 7 to Drupal 8 Migration path, which are the remaining ones (correct that if wrong), have an entry in the appropriate module in the 'not_finished' section of the state file.

Proposed resolution

Create a test for drupal 6 and drupal 7, and move the test code to a trait.

Remaining tasks

Patch
Check that all the remaining migrations have an entry in the 'not_finished' section.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 3069541-9.patch8.91 KBquietone
#9 reroll_diff-4-9.txt718 bytesquietone
#7 3069541-7.patch11.54 KBquietone
#4 3069541-4.patch8.9 KBquietone
#4 interdiff-2-4.txt2.93 KBquietone
#2 3069541-2.patch5.97 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Active » Needs review
FileSize
3069541-2.patch5.97 KB

This adds the d6 and d7 version of the tests. There will be failures in the ReviewPage tests.

Status: Needs review » Needs work

The last submitted patch, 2: 3069541-2.patch, failed testing. View results

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs work » Needs review
FileSize
interdiff-2-4.txt2.93 KB
3069541-4.patch8.9 KB

And now update the functional tests

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Needs a re-roll based on changes to content_translation.migrate_drupal.yml.

But otherwise, this is looking really nice.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs work » Needs review
FileSize
3069541-7.patch11.54 KB

Rerolled. The making of the interdiff fails. The changes were to content_translation.migrate_drupal.yml and UPgrade7Test.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Needs work
Issue tags: -Needs reroll 
+++ b/core/modules/content_translation/migrations/state/content_translation.migrate_drupal.yml
@@ -29,11 +29,19 @@ not_finished:
diff --git a/core/modules/migrate_drupal/tests/src/Kernel/d6/ValidateMigrationStateTest.php b/core/modules/migrate_drupal/tests/src/Kernel/d6/ValidateMigrationStateTest.php
new file mode 100644

+++ b/core/modules/migrate_drupal/tests/src/Kernel/d6/ValidateMigrationStateTest.php
@@ -0,0 +1,25 @@
diff --git a/core/modules/migrate_drupal/tests/src/Kernel/d7/ValidateMigrationStateTest.php b/core/modules/migrate_drupal/tests/src/Kernel/d7/ValidateMigrationStateTest.php
new file mode 100644

+++ b/core/modules/migrate_drupal/tests/src/Kernel/d7/ValidateMigrationStateTest.php
@@ -0,0 +1,25 @@
diff --git a/core/modules/migrate_drupal/tests/src/Kernel/ValidateMigrationStateTest.php b/core/modules/migrate_drupal/tests/src/Traits/ValidateMigrationStateTestTrait.php
similarity index 91%

rename from core/modules/migrate_drupal/tests/src/Kernel/ValidateMigrationStateTest.php
rename to core/modules/migrate_drupal/tests/src/Traits/ValidateMigrationStateTestTrait.php

These changes are missing in the re-roll. Is that intentional?

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs work » Needs review
FileSize
reroll_diff-4-9.txt718 bytes
3069541-9.patch8.91 KB

Thanks heddn, that was a mistake. Here is new reroll of the patch in #4.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Reviewed & tested by the community

And now back to RTBC.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed 6e5a06e and pushed to 8.8.x. Thanks!

  • larowlan committed 6e5a06e on 8.8.x 
    Issue #3069541 by quietone, heddn: ValidateMigrationState should load...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.