I have provided a simple fix to allow this function to properly work with both mysqli and mysql.

CommentFileSizeAuthor
devel-devel-module-1.patch394 bytesbrendoncrawford
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

Looks OK to me. Anyone see a problem?

brendoncrawford’s picture

brendoncrawford CreditAttribution: brendoncrawford commented

Moshe,

The line in question clearly shows:

  $qids[$hash] = mysql_insert_id();

This will not work with mysqli.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

Indeed. I should have asked - anyone see a problem with the proposed fix?

brendoncrawford’s picture

brendoncrawford CreditAttribution: brendoncrawford commented

Ok, now I see what you meant. I misunderstood your phrasing.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Fixed

What the heck - committed.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.