Problem/Motivation

I am in a case where we re-use SVGs and they are not getting exported.

SVG's markup:
<svg><use xlink:href="/some-icon.svg"></use></svg></span>

CommentFileSizeAuthor
#5 interdiff-3067593-2-5.txt2.83 KBsamuel.mortenson
#5 3067593-5.patch2.89 KBsamuel.mortenson
#2 tome-export_svgs-3067593.patch630 bytesnikolabintev
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nikolabintev created an issue. See original summary.

nikolabintev’s picture

nikolabintev CreditAttribution: nikolabintev commented
FileSize
tome-export_svgs-3067593.patch630 bytes

I'm uploading a patch that iterates over all `svg` tags and exports their paths from the "xlink:href" attribute

nikolabintev’s picture

nikolabintev CreditAttribution: nikolabintev commented
Status: Active » Needs review
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented

Looks good, thanks @nikolabintev! This does need tests added to \Drupal\Tests\tome_static\Kernel\StaticGeneratorTest::testComplexHtml but I can probably do that before commit next week if no one else adds it before then.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
FileSize
3067593-5.patch2.89 KB
interdiff-3067593-2-5.txt2.83 KB

Added tests.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Needs review » Fixed

  • samuel.mortenson authored fc72404 on 8.x-1.x 
    Issue #3067593 by samuel.mortenson, nikolabintev: Export referenced SVGs
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.