This module was deprecated once jQuery UI was moved into core, however now there is discussion about deprecating jQuery UI from core.
Since many contrib modules and themes depend on jQuery UI in Drupal core, a suggestion in that thread is to provide the jQuery UI libraries in contrib so even after they are removed or replaced in core, a developer could have a drop in replacement by changing any reference for core/jquery.ui
to jquery_ui/core
.
An 8.x branch for this module would be a perfect place to provide the core jQuery UI library.
The module would just need to contain an info file, libraries file and the css and js assets currently in core/vendor/jquery.ui
jquery_ui |_jquery.ui | |_ui | | |_widgets | | | |_...common js files | | | | | |...other js files | | | |_themes | |_base | |_...css files | |_jquery_ui.info.yml |_jquery_ui.libraries.yml
Other modules would provide the other jQuery UI libraries like accordion, checkboxradio etc but depend on this module for core jQuery UI.
The libraries file in this module could also include utilities those other libraries depend on, such as widget, mouse and position.
Comment | File | Size | Author |
---|---|---|---|
#5 | interdiff-2-5.txt | 4.77 KB | zrpnr |
#5 | create-d8-branch-5.patch | 42.12 KB | zrpnr |
Comments
Comment #2
zrpnrI rolled a patch off the 7.x-1.x branch to illustrate the changes I described.
This adds the jQuery UI base css and js, removes install and module files, changes info to info.yml and includes the jquery.ui and some utility libraries form D8 core.
Comment #3
lauriiiConfirmed on Slack that this could use review 🙂
Comment #4
mikelutzJust applied this to check it out. Looks good, but we need to update the CHANGELOG and README files too, as they are not correct for this new version.
Comment #5
zrpnrThanks for taking a look at this! I wasn't sure what to put for the CHANGELOG or README, but I updated the CHANGELOG with the 8.x info and added a version of the README I used in the other jQuery UI projects.
Comment #6
mikelutzThis looks right, I'm going to RTBC it to try to get a -dev branch opened for D8, and we can iterate on it there if needed.
Comment #7
webchickAdded @mikelutz and @zrpnr (who was already there). Do your thing! :)
Comment #8
webchickAnd I believe this should be fine, since:
- According to https://www.drupal.org/node/260942/revisions, the project was originally created by me
- It was also last committed to 8 years ago, so I think can be considered "inactive"
Comment #9
mikelutzComment #10
mikelutz