Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Charlie ChX Negyesi created an issue. See original summary.

amateescu’s picture

Status: Needs review » Needs work

Since we're changing that line, it would be useful to also say a few words about the return value.

And let's add a blank line between the last @param and @return.

Ghost of Drupal Past’s picture

Status: Needs work » Needs review
FileSize
719 bytes

Thanks for the speedy review! BTW a much bigger issue can be seen in $class::buildBasicRenderable($view_id, $display_id, $args, $route); because the interface only defines three arguments and this "leaks" the Page implementation.

Ghost of Drupal Past’s picture

FileSize
694 bytes
amateescu’s picture

Status: Needs review » Reviewed & tested by the community

Perfect :)

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed ee9bc9d and pushed to 8.8.x. Thanks!

  • catch committed ee9bc9d on 8.8.x
    Issue #3065595 by Charlie ChX Negyesi: ViewPageController::handle()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.