Drupal 8.6.x still has security support until December (see https://www.drupal.org/core/release-cycle-overview#overview ), so we probably want to postpone this until then, but once we require 8.7.x we will want to use EntityOwnerTrait (see https://www.drupal.org/node/2998929 ) in EnhancedEntityWithOwner.

CommentFileSizeAuthor
#7 3065163-7.patch6.61 KBiyyappan.govind
#5 3065163-5.patch6.33 KBtstoeckler
#5 3065163-4-5-interdiff.txt3.26 KBtstoeckler
#4 3065163-4.patch3.07 KBtstoeckler
#4 3065163-3-4-interdiff.txt597 byteststoeckler
#3 3065163-2.patch2.83 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Issue summary: View changes
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Active » Postponed
FileSize
3065163-2.patch2.83 KB

This works for me. Postponing, because testing runs on 8.6.x for now.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Related issues: +#3065338: Prepare for 8.7 deprecations/changes
FileSize
3065163-3-4-interdiff.txt597 bytes
3065163-4.patch3.07 KB

Missed the actual entity key change due to overlaps with #3065338: Prepare for 8.7 deprecations/changes

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
FileSize
3065163-4-5-interdiff.txt3.26 KB
3065163-5.patch6.33 KB

Moving one thing from #3065338: Prepare for 8.7 deprecations/changes here as that's not compatible with 8.6.x

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman as a volunteer commented
Status: Postponed » Needs work 
+++ b/entity.info.yml
@@ -3,4 +3,4 @@ description: Provides expanded entity APIs, which will be moved to Drupal core o
-  - drupal:system (>=8.6.0)
+  - drupal:system (>=8.7.0)

There is a composer.json for the module which needs to be updated as well (https://git.drupalcode.org/project/entity/blob/8.x-1.x/composer.json)

iyyappan.govind’s picture

iyyappan.govind
he/him
Primary language Tamil
Location Chennai, India
CreditAttribution: iyyappan.govind at UniMity Solutions Pvt Limited commented
Status: Needs work » Needs review
FileSize
3065163-7.patch6.61 KB

Hi I have modified the drupal core version in composer.json file. But test runs in 8.6. Please review the patch. Thanks

iyyappan.govind’s picture

iyyappan.govind
he/him
Primary language Tamil
Location Chennai, India
CreditAttribution: iyyappan.govind at UniMity Solutions Pvt Limited commented

How to run this test on 8.7?

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

Committed #3065338: Prepare for 8.7 deprecations/changes and #3065178: Support the "owner" key in QueryAccessHandlerBase in preparation for this patch.

  • bojanz committed 5eed315 on 8.x-1.x authored by tstoeckler 
    Issue #3065163 by tstoeckler, iyyappan.govind, mglaman: Require Drupal 8...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Tests are passing, tweaked composer.json and committed. Thanks, everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.