In the 3.20 release the modal title has also the attributes of the modal header - namely, the "modal-header" class.

I don't know if this is a intentional behavior; judging by the result I suspect not. Anyway this may break the layout for existing sites.

The culprit is in the line 523 and following of "Modal.js":

        if (typeof variables.title === 'string') {
          variables.title = $.extend({}, defaults, { content: variables.title });
        }

$.extend also merge the attributes of the var defaults, which contains the aforementioned "modal-header" class.

CommentFileSizeAuthor
#4 3064547-4.patch1.1 KBmarkhalliwell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Giuseppe87 created an issue. See original summary.

Giuseppe87’s picture

Title: Modal title inherit modal header's attributes » Modal title inherits modal header's attributes
markhalliwell’s picture

Title: Modal title inherits modal header's attributes » Modal title inherits header attributes
Version: 8.x-3.x-dev » 8.x-4.x-dev
markhalliwell’s picture

Status: Active » Fixed
FileSize
1.1 KB

  • markcarver committed 56ca66a on 8.x-4.x
    Issue #3064547 by markcarver, Giuseppe87: Modal title inherits header...

  • markcarver committed aa2250d on 8.x-3.x
    Issue #3064547 by markcarver, Giuseppe87: Modal title inherits header...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.