Now DCD depends from version 1.0-alpha7 of default_content module, but 1.0-alpha8 is out. So I can't upgrade it without breaking the dependency. Fix it with "drupal/default_content": "^1.0", not "drupal/default_content": "1.0-alpha7".

CommentFileSizeAuthor
#2 fix_default_content_dependency-3064093-2-D8.patch300 bytesarnaldop
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Andrew Answer created an issue. See original summary.

arnaldop’s picture

arnaldop
Location St Cloud, FL
CreditAttribution: arnaldop as a volunteer commented
Priority: Normal » Major
FileSize
fix_default_content_dependency-3064093-2-D8.patch300 bytes

Here is a patch that solves this problem. It still couples this alpha release to the alpha release of default_content, but it's no longer a specific, now outdated, release.

Unfortunately, I wasn't able to apply it using the cweagans/composer-patches. This may be the case because it's not patching code, but the composer.json file, which almost creates a race condition...

Perhaps now that this patch file is not local, but rather external, the extra/patches mechanism might pick it up and "fix everything".

I marked this as major because, unless I'm wrong, which I often am, there is no reason to couple this release of default_content_deploy with default_content release alpha7. Minor versions should be non-breaking, so it should not matter which alpha release is used. (This could be a bit of wishful thinking, but a guy can hope!)

Andrew Answer’s picture

Andrew Answer CreditAttribution: Andrew Answer as a volunteer commented

@arnaldop,

thank you for your fix, it's applied, but I cannot update default_content module anyway. Probably, it can be allowed only if DCD owners commit your patch to dev version, at least.

ivnish’s picture

ivnish CreditAttribution: ivnish commented
Status: Active » Reviewed & tested by the community
ivnish’s picture

ivnish CreditAttribution: ivnish commented

Please commit this to dev

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kiev / Toronto
CreditAttribution: alphawebgroup as a volunteer and at Alpha Web Group for Alpha Web Group commented

Hey, any chance to get that committed?

simoneb’s picture

simoneb CreditAttribution: simoneb commented

any news on this?

  • martin_klima committed 0faf8ff on 8.x-1.x authored by arnaldop 
    Issue #3064093 by arnaldop, Andrew Answer, ivnish: Fix default_content...
martin_klima’s picture

martin_klima
he/his
Primary language Czech
CreditAttribution: martin_klima as a volunteer and at Czech Drupal Association commented
Status: Reviewed & tested by the community » Fixed

Thank you guys and very sorry for the late reaction.

simoneb’s picture

simoneb CreditAttribution: simoneb commented

Hi,

I just tried composer require 'drupal/default_content_deploy:1.x-dev'

But I get this one

The requested package drupal/default_content ^1.x-dev exists as drupal/default_content[dev-1.x, 1.x-dev, 1.0.0-alpha8, 1.0.0-alpha7, 1.0.0-alpha6, 1.0.0-alpha5, 1.0.0-alpha4, 1.0.0-alpha3, 1.0.0-alpha2, 1.0.0-alpha1, dev-8.x-1.x, dev-uuid-tree] but these are rejected by your constraint.

Thanks

PS: "minimum-stability": "dev"

martin_klima’s picture

martin_klima
he/his
Primary language Czech
CreditAttribution: martin_klima as a volunteer and at Czech Drupal Association commented

I checked it again without any problem.
composer require 'drupal/default_content_deploy:1.x-dev' works normally for me.

Could it be a problem in typo? You asked for default_content_deploy, but your Composer message is:
> The requested package drupal/default_content ^1.x-dev exists as... So maybe you asked for default_content:1.x-dev.

simoneb’s picture

simoneb CreditAttribution: simoneb commented

Removing default_content and better_normalizers from composer.json and run composer require 'drupal/default_content_deploy:1.x-dev' fixed the issue for me.

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.