Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Double-clicking on link within editable caption launches drupallink dialog. Updating the link fails to update the saved markup.
https://www.drupal.org/files/issues/2019-06-15/caption%20link%20bug.mov
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#9 | 3062034-9.patch | 3.05 KB | Wim Leers |
| |||
#9 | interdiff.txt | 1.49 KB | Wim Leers |
#7 | 3062034-7.patch | 2.77 KB | oknate |
| |||
#7 | 3062034-7--TEST-ONLY.patch | 1.96 KB | oknate |
#2 | 3062034-2--TEST-ONLY.patch | 1.46 KB | oknate |
Comments
Comment #2
oknateTest only patch, should fail. It demonstrates the bug.
Comment #3
oknateComment #4
oknateInterestingly, the change is present if you view the editable caption this way:
But if you press the source button, it doesn't show.
Also, if you hit the "Save" button and check the output on the saved host node, it doesn't show the change.
Comment #6
oknateIf you put a print statement in captionEditableMutationObserver, you'll see it's not called when the link is edited with the drupalink dialog.
Comment #7
oknateIt works if you set attributes to true in the mutation observer:
Is that going to break something else? What was the rationale behind setting that to false?
Comment #9
Wim LeersGreat find, correct fix, I only want to tweak the test coverage a bit.
Comment #11
Wim Leers🚢
Comment #12
oknateFantastic, thanks!
Comment #13
Wim Leers