At the moment, the UI only has a single checkbox for Smart Delete. The issue I marked as related fixed what was broken about this feature.

In the code, I see variables for backup_migrate_smart_keep_subhourly, backup_migrate_smart_keep_hourly, backup_migrate_smart_keep_daily, and backup_migrate_smart_keep_weekly, as well as a commented out usage of $keep_monthly inside smart_delete_backups().

I'm getting to the point, now that I have the related patch applied that fixed smart keep, that my projects are accumulating weekly backups. I don't want to keep weekly backups forever and would prefer to keep only monthly backups after an amount of time.

It would be really nice if there was a way to set these variables in the settings UI for a schedule. And it would be great if support for monthly backup keeping could be added, since it's pretty much there but just commented out, and it wouldn't take much to support.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

solideogloria created an issue. See original summary.

DamienMcKenna’s picture

solideogloria’s picture

This was pretty easy to add, as it only involved adding three settings, and the variables already existed.

I did not include monthly backups due to the conversation elsewhere about it actually being 4 weeks, not an exact month. The $keep_monthly code that is in the module is still commented out, but remains for those who want it.

solideogloria’s picture

DamienMcKenna’s picture

Status: Needs review » Fixed

Committed. Thank you!

FYI I added the variables to hook_uninstall(), for good measure.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.