Use dropbutton variants with #dropbutton_type instead of custom classes

Postponed this until #3057581: Add support for Dropbutton variants gets done.

Manual testing of the patch resulted in a failure to apply on latest dev build.

Comment for the googlers out there - dropbuttons for things like the paragraphs widget break in both the alpha and latest dev release, I believe as a result of this issue. Using a different form widget is a work around.

#3057581: Add support for Dropbutton variants is RTBc, hopefully this is soon unblocked 🤞

#3057581: Add support for Dropbutton variants is in. Marking this for review.

Rerolled the patch, based on patch in #2

I tried to create an interdiff, but it won't make any sense...

+++ b/core/themes/claro/claro.theme
@@ -242,9 +242,13 @@ function claro_element_info_alter(&$type) {
+    // We need to specify #dropbutton_type before the default prerender happens.

Would it be possible to explain why this is needed?

Otherwise this looks good 👏I cleared caches and tested both tables with operations and Views UI and they work as expected. ✨

Addressing #17.

Thank you for adding the clarification on why it was needed. It makes sense now ✌️

Tested manually to confirm that there are no visual changes on the content list or block UI and everything seems to work as expected 👏

Rebased #20.

Rebased patch #20.

The changes since #21 look good.

The patch applied cleanly

Moved this to 9.1 and the patch still applies cleanly.

1. It looks like this will require an update hook as I got a WSOD due the change to trustedCallbacks in ClaroPreRender not being fully acknowledged. A cache clear addressed this.

2. +++ b/core/themes/claro/claro.theme
   @@ -242,9 +242,17 @@ function claro_element_info_alter(&$type) {
   +    // In Claro, Operations should always use the extrasmall dropbutton variant.
   +    // While the string value of the #dropbutton_type is added as component
   +    // modifier CSS class in
   +    // \Drupal\Core\Render\Element\Dropbutton::preRenderDropbutton, we have to
   +    // specify #dropbutton_type before the default prerender happens
   

   I think this could be a little easier to understand if this is rearranged a little. Maybe start with "#dropbutton_type must be placed before the default renderer because..."

Addressing #34

Looks good! Just two doc nits, the implementation is great.

1. +++ b/core/themes/claro/claro.theme
   @@ -245,9 +245,17 @@ function claro_element_info_alter(&$type) {
   +  // Add a pre-render function for Operations to set dropbutton_type.
   

   add # to dropbutton_type

2. +++ b/core/themes/claro/claro.theme
   @@ -245,9 +245,17 @@ function claro_element_info_alter(&$type) {
   +    // In Claro, Operations should always use the extrasmall dropbutton variant.
   +    // Adding CSS classes for variants requires the element to have
   +    // the #dropbutton_type property by the time it reaches
   +    // \Drupal\Core\Render\Element\Dropbutton::preRenderDropbutton.
   +    // This ensures #dropbutton_type is available to preRenderDropbutton.
   

   There's some odd wrapping on this comment, and missing () on the method names

TY @tim.plunkett This addresses #36

Thanks!

Re-rolling as it failed to apply

Thanks so much! Those post_updates clash so often.

Also, on a clean reroll, no need to unRTBC! Only if you made substantive changes (which isn't really a reroll) or were unsure about conflicts that needed resolving.

Committed 0551c86 and pushed to 9.1.x. Thanks!