According to this issue with the new Admin UI Design Claro, we're willing to fix the views names sizing on the views listing. Out of the linked issue:

I came across /admin/structure/views and saw that the view names in that list are visually way too big in my opinion (they are even bigger than the list headline 'view name' row headline). It's a h3 causing that issue. See screenshot attached.

I would suggest that it should look like the block region name here /admin/structure/block

seven
claro

CommentFileSizeAuthor
#11 3059872-11.drupal.Resize-view-names-on-view-list.patch843 bytesfhaeberle
#7 3059872-7.drupal.Resize-view-names-on-view-list.patch4.1 KBfhaeberle
#7 interdiff.3059872.4-7.txt3.27 KBfhaeberle
#4 3059872-4.drupal.Resize-view-names-on-view-list.patch855 bytesfhaeberle
view-name-too-big-claro.png652.68 KBfhaeberle
view-name-too-big-seven.png551.1 KBfhaeberle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fhaeberle created an issue. See original summary.

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
CreditAttribution: fhaeberle at Tojio // Digital Agency commented
Issue summary: View changes
fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
CreditAttribution: fhaeberle at Tojio // Digital Agency commented
Issue summary: View changes
fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
CreditAttribution: fhaeberle at Tojio // Digital Agency commented
FileSize
3059872-4.drupal.Resize-view-names-on-view-list.patch855 bytes

I provided a patch with the small change. We should not use the <h3> in a table at all so I changed it to a <strong>. This change is not to make the font look bold (this is only a side effect), but to display it in a semantic correct way.

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
CreditAttribution: fhaeberle at Tojio // Digital Agency commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 3059872-4.drupal.Resize-view-names-on-view-list.patch, failed testing. View results

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
CreditAttribution: fhaeberle at Tojio // Digital Agency commented
FileSize
interdiff.3059872.4-7.txt3.27 KB
3059872-7.drupal.Resize-view-names-on-view-list.patch4.1 KB

Applied patch for updated test because test fails with the changed markup.

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
CreditAttribution: fhaeberle at Tojio // Digital Agency commented
Status: Needs work » Needs review
thamas’s picture

thamas
Primary language Hungarian
Location Hungary
CreditAttribution: thamas as a volunteer commented
Status: Needs review » Reviewed & tested by the community

It seems to be OK. :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work 
  1. index 0000000000..5403585b0e
--- /dev/null

--- /dev/null
+++ b/3059872-4.drupal.Resize-view-names-on-view-list.patch

+++ b/3059872-4.drupal.Resize-view-names-on-view-list.patch
@@ -0,0 +1,13 @@

@@ -0,0 +1,13 @@
+diff --git a/core/themes/stable/templates/admin/views-ui-views-listing-table.html.twig b/core/themes/stable/templates/admin/views-ui-views-listing-table.html.twig
+index bc12a0a6ef..e1d0c1cf34 100644
+--- a/core/themes/stable/templates/admin/views-ui-views-listing-table.html.twig
++++ b/core/themes/stable/templates/admin/views-ui-views-listing-table.html.twig
+@@ -27,7 +27,7 @@
+     {% for row in rows %}
+       <tr{{ row.attributes }}>
+         <td class="views-ui-view-name">
+-          <h3 data-drupal-selector="views-table-filter-text-source">{{ row.data.view_name.data }}</h3>
++          <strong data-drupal-selector="views-table-filter-text-source">{{ row.data.view_name.data }}</strong>
+         </td>
+         <td class="views-ui-view-machine-name" data-drupal-selector="views-table-filter-text-source">
+           {{ row.data.machine_name.data }}

    This looks like it has been included in error. 

  2. +++ b/core/themes/stable/templates/admin/views-ui-views-listing-table.html.twig
@@ -27,7 +27,7 @@
-          <h3 data-drupal-selector="views-table-filter-text-source">{{ row.data.view_name.data }}</h3>
+          <strong data-drupal-selector="views-table-filter-text-source">{{ row.data.view_name.data }}</strong>

    We shouldn't be changing stable. It's not suppose to change in Drupal 8. As it implies stable is not supposed to change. We should be changing core/modules/views_ui/templates/views-ui-views-listing-table.html.twig as this is the version that can. Changing it there also means that the test doesn't change yet. It might be nice to make the test not so reliant on the markup if possible.

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
CreditAttribution: fhaeberle at Tojio // Digital Agency commented
Status: Needs work » Needs review
FileSize
3059872-11.drupal.Resize-view-names-on-view-list.patch843 bytes

@alexpott I followed you suggestion and changed it in the right file.

thamas’s picture

thamas
Primary language Hungarian
Location Hungary
CreditAttribution: thamas at Mirum Agency commented

This became a really subtle code change, I can't see any problem with it.

I do not know if it needs anything else (eg. + test file).

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Title: Resize view names on view list » View names on view list table shouldn't be headings
Status: Needs review » Reviewed & tested by the community
Issue tags: +Accessibility

The change looks good. Since this is affecting only Views UI, I think it's fine to not have a change record. Moving to RTBC.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.7.3 » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

Committed cc92b90 and pushed to 8.8.x. Thanks!

  • catch committed 5d68f9f on 8.8.x 
    Issue #3059872 by fhaeberle, alexpott: View names on view list table...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

btw agreed on no change record here.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.