The Media Library module is not properly capitalized. It's named as "Media library" in core, and should be changed to "Media Library".

Module naming convention explained in https://www.drupal.org/node/604342#interface-text-capitalization

CommentFileSizeAuthor
#8 Screen Shot 2019-06-02 at 7.44.59 PM.png54.41 KBalonaoneill
#7 media_library_name-3058943-6.patch5.13 KBMohammed J. Razem
#5 media_library_name-3058943-2.patch5.13 KBMohammed J. Razem
#2 media_library_name-3058943-1.patch484 bytesMohammed J. Razem
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mohammed J. Razem created an issue. See original summary.

Mohammed J. Razem’s picture

Mohammed J. Razem
Location Santa Clara, CA
CreditAttribution: Mohammed J. Razem at Vardot commented
FileSize
media_library_name-3058943-1.patch484 bytes

Patch attached.

Mohammed J. Razem’s picture

Mohammed J. Razem
Location Santa Clara, CA
CreditAttribution: Mohammed J. Razem at Vardot commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: media_library_name-3058943-1.patch, failed testing. View results

Mohammed J. Razem’s picture

Mohammed J. Razem
Location Santa Clara, CA
CreditAttribution: Mohammed J. Razem at Vardot commented
Status: Needs work » Needs review
FileSize
media_library_name-3058943-2.patch5.13 KB

Updated patch that changes the capitalization wherever Media Library is in context of a proper name in English.

Status: Needs review » Needs work

The last submitted patch, 5: media_library_name-3058943-2.patch, failed testing. View results

Mohammed J. Razem’s picture

Mohammed J. Razem
Location Santa Clara, CA
CreditAttribution: Mohammed J. Razem at Vardot commented
Status: Needs work » Needs review
FileSize
media_library_name-3058943-6.patch5.13 KB

Ah! One more time. I missed the documentation link name fix.

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screen Shot 2019-06-02 at 7.44.59 PM.png54.41 KB

Code looks good, the name of the module is now capitalized on the Extend page. Screenshot provided."
Marking as RTBC
Thank you for working on the module!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

I checked all the occurrences in core and can't find any instances where Media Library is referenced as a module that are not updated so we're good to go here. We are likely to regress here I guess but /shrug I can't see what to do about that.

Committed and pushed 1094d0c8d1 to 8.8.x and a807fa863a to 8.7.x. Thanks!

  • alexpott committed 1094d0c on 8.8.x 
    Issue #3058943 by Mohammed J. Razem, alonaoneill: Fix Media Library...

  • alexpott committed a807fa8 on 8.7.x 
    Issue #3058943 by Mohammed J. Razem, alonaoneill: Fix Media Library...
maximpodorov’s picture

maximpodorov CreditAttribution: maximpodorov commented

Excuse me, is there any requirement to capitalize the names of modules themselves (not references to modules)?

Mohammed J. Razem’s picture

Mohammed J. Razem
Location Santa Clara, CA
CreditAttribution: Mohammed J. Razem at Vardot commented

@maximpodorov yes.

Module naming convention explained in https://www.drupal.org/node/604342#interface-text-capitalization

maximpodorov’s picture

maximpodorov CreditAttribution: maximpodorov commented

No. This guide says about the situation of referencing existing modules, not about assigning names to modules.

maximpodorov’s picture

maximpodorov CreditAttribution: maximpodorov commented

So can we consider all such requests to change module names as incorrect ones?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented

@maximpodorov the standard in core for module names is title case. See core/modules/block_content/block_content.info.yml, core/modules/automated_cron/automated_cron.info.yml, core/modules/block_place/block_place.info.yml, core/modules/config_translation/config_translation.info.yml, core/modules/content_moderation/content_moderation.info.yml, core/MAINTAINERS.txt etc...

maximpodorov’s picture

maximpodorov CreditAttribution: maximpodorov commented

OK. So we can consider all such requests to change CONTRIB module names as incorrect ones.

Mohammed J. Razem’s picture

Mohammed J. Razem
Location Santa Clara, CA
CreditAttribution: Mohammed J. Razem at Vardot commented

@maximpodorov - Go to https://www.drupal.org/docs/develop/documenting-your-project/help-text-s...
It describes the convention there for both core and contrib modules.

You should follow the guidelines for user interface text in general: https://drupal.org/node/604342, and in particular:

  • Capitalize the name of the module, because module names are proper nouns.
  • Make sure that titles of links to administration pages and tabs are identical to the page and tab titles.
  • Do not refer to Drupal but rather to your website or similar, because the module might be used in other distributions and the user might not be aware that they are using Drupal.
maximpodorov’s picture

maximpodorov CreditAttribution: maximpodorov commented

Exactly. But "When referring to the name of a module". It's not about the module name itself.

Mohammed J. Razem’s picture

Mohammed J. Razem
Location Santa Clara, CA
CreditAttribution: Mohammed J. Razem at Vardot commented

I reset my case.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.