Summary:
Currently, when submitting the views form, the ENTITY_TYPE_list cache tag, this forces any custom use of draggableviews rely on the ENTITY_TYPE_list cache tag and this would potentially have a big impact on the page performance.
According to the documentation:
node_list — list cache tag for Node entities (invalidated whenever any Node entity is updated, deleted or created, i.e. when a listing of nodes may need to change).
Solution
We need another way to invalidate the cache of the "sorting".
As the first approach, we propose to keep the ENTITY_TYPE_list cache tag invalidation and add a new cache tag invalidation for the view configuration. This will let third-party integrations to invalidate the cache when a draggable views form get submitted without invalidating all the ENTITY_TYPE_list cache.
Comment | File | Size | Author |
---|---|---|---|
#2 | draggableviews-3057906-2.patch | 1011 bytes | akalam |
Comments
Comment #2
akalam CreditAttribution: akalam at Metadrop commentedPatch attached adding the view configuration cache tag to the list of tags to invalidate.
Comment #3
akalam CreditAttribution: akalam at Metadrop commentedComment #4
akalam CreditAttribution: akalam at Metadrop commentedComment #5
akalam CreditAttribution: akalam at Metadrop commentedComment #6
ducktape CreditAttribution: ducktape at District09 commentedThis looks good. I tested the patch in our project and it does what it needs to do.
Comment #8
iStryker CreditAttribution: iStryker commentedThe related issues are for the next version of Drupal Core, however, I tested with 8.7 of Drupal Core and it does not throw any errors. Committing
Comment #9
akalam CreditAttribution: akalam at Metadrop commentedThank you for commiting it!