Problem/Motivation

phpstan 0.11.8 and phpstan-deprecation-rules 0.11.2 were released recently with support for @deprecation rule printing. We should use them now. phpstan-drupal keeps being incompatible with nette 3 though, so we need to exclude those.

Proposed resolution

Do it.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#15 Screenshot 2019-07-10 at 17.13.21.png151.89 KBGábor Hojtsy
#10 Bildschirmfoto 2019-06-12 um 14.00.26.png304.62 KBkfritsche
#6 3057853-6.patch734 bytesGábor Hojtsy
#2 3057853.patch613 bytesGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy created an issue. See original summary.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
FileSize
3057853.patch613 bytes

  • Gábor Hojtsy committed ad7f6e1 on 8.x-1.x 
    Issue #3057853 by Gábor Hojtsy: Update to new PHPStan version for @...

  • Gábor Hojtsy committed 67eb199 on 8.x-1.x 
    Issue #3057853 by Gábor Hojtsy: Roll back to specific old PHPStan...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Active » Postponed

I rolled this back due to incompatibilties between phpstan-drupal and phpstan requirements. Conflicts documented on https://github.com/phpstan/phpstan/issues/2150#issuecomment-496930998 in the phpstan realm at least. phpstan-drupal rules out nette/di 3 so it cannot take a phpstan needing nette/schema 1 so I rolled back to two phpstan versions back for now.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Postponed » Fixed
FileSize
3057853-6.patch734 bytes

phpstan-drupal update was released, taking the new versions then.

  • Gábor Hojtsy committed 9cdaa1d on 8.x-1.x 
    Issue #3057853 by Gábor Hojtsy: Update to new PHPStan version for @...

  • Gábor Hojtsy committed 811fb61 on 8.x-1.x 
    Revert "Issue #3057853 by Gábor Hojtsy: Update to new PHPStan version...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Fixed » Postponed

I put this on a separate branch for now given the issues that turned out to be more complicated then anticipated. In the meantime people have more pressing issues with alpha3 that we should resolve so we should not keep this on the main 1.x branch until it works cleanly.

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
CreditAttribution: kfritsche at bio.logis Genetic Information Management GmbH commented
FileSize
Bildschirmfoto 2019-06-12 um 14.00.26.png304.62 KB

With my comment in https://github.com/mglaman/phpstan-drupal/pull/71 the upgrade to newest version of phpstan would work.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented 
+++ b/composer.json
@@ -6,15 +6,11 @@
+        "phpstan/phpstan": "^0.11.8@dev",
+        "phpstan/phpstan-deprecation-rules": "^0.11.2@dev",

Remove @dev?

Could this be committed and I will work on a fix in phpstan-drupal, as HEAD isn't working anyways, correct?

  • Gábor Hojtsy committed 0cb2665 on 8.x-1.x 
    Issue #3057853 by Gábor Hojtsy, kfritsche: Update to new PHPStan version...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Postponed » Fixed

Committed this again so @mglaman has an easier time to work out a fix on the phpstan-drupal side where the bug looks like is.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue summary: View changes
FileSize
Screenshot 2019-07-10 at 17.13.21.png151.89 KB

This allowed to further categorize results, so now we have this UI:

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented

Excellent! Thanks!