Problem/Motivation

Drupal asked for use of method $this->t()

Proposed resolution

Use the StringTranslationTrait on Tests/CaptchaBaseWebTestCase.php which is abstracted on Tests/CaptchaPersistenceTestCase

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thalles created an issue. See original summary.

thalles’s picture

wundo’s picture

Status: Needs review » Needs work
Parent issue: » #3086055: Plan for CAPTCHA 7.x-1.7 release

Patch needs reroll

Dinesh18’s picture

Status: Needs work » Needs review
FileSize
4.99 KB

Here is the updated patch which implements #2.
Kindly review it

wundo’s picture

Status: Needs review » Needs work
Dinesh18’s picture

Here is the updated Patch

wundo’s picture

Thanks Dinesh, looks better :)

Could you please move the trait itself (and the use) to CaptchaPersistenceTest.php please?

Dinesh18’s picture

Here is the updated patch as per the changes mentioned

wundo’s picture

Status: Needs review » Reviewed & tested by the community

Awesome, thank you!

wundo’s picture

Status: Reviewed & tested by the community » Fixed

  • wundo committed af616f2 on 8.x-1.x authored by Dinesh18
    Issue #3057592 by Dinesh18, wundo: Use StringTranslationTrait on Tests/...
wundo’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.