LayoutBuilderDisableInteractionsTest randomly fails

Let's try to see what's happening.

So looking at https://dispatcher.drupalci.org/job/drupal_patches/99033/artifact/jenkin... it doesn't look like the iFrame thing :(

What really interesting is that I can't get this test to pass locally at all. I fail with

Testing Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderDisableInteractionsTest
E                                                                   1 / 1 (100%)

Time: 10.14 seconds, Memory: 6.00MB

There was 1 error:

1) Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderDisableInteractionsTest::testFormsLinksDisabled
Exception: element click intercepted: Element <input data-drupal-selector="edit-submit" type="submit" id="edit-submit--UfVqg5ISAfs" value="Search" class="button js-form-submit form-submit" disabled="" tabindex="-1"> is not clickable at point (220, 389). Other element would receive the click: <div data-drupal-selector="edit-actions" class="form-actions js-form-wrapper form-wrapper" id="edit-actions--ku6j-kPGJZY">...</div>
  (Session info: headless chrome=74.0.3729.169)
  (Driver info: chromedriver=74.0.3729.6 (255758eccf3d244491b8a1317aa76e1ce10d57e9-refs/branch-heads/3729@{#29}),platform=Mac OS X 10.14.5 x86_64)

/Users/alex/dev/sites/drupal8alt.dev/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:144
/Users/alex/dev/sites/drupal8alt.dev/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:157
/Users/alex/dev/sites/drupal8alt.dev/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:218
/Users/alex/dev/sites/drupal8alt.dev/vendor/instaclick/php-webdriver/lib/WebDriver/Container.php:224
/Users/alex/dev/sites/drupal8alt.dev/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:775
/Users/alex/dev/sites/drupal8alt.dev/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:763
/Users/alex/dev/sites/drupal8alt.dev/vendor/behat/mink/src/Element/NodeElement.php:153
/Users/alex/dev/sites/drupal8alt.dev/core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderDisableInteractionsTest.php:187
/Users/alex/dev/sites/drupal8alt.dev/core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderDisableInteractionsTest.php:205
/Users/alex/dev/sites/drupal8alt.dev/core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderDisableInteractionsTest.php:114

Which is a different fail to the random one AND it's not random - it fails every time.

So here's a fix for the local fail so at least this passes for me.

What's weird is how does \WebDriver\Exception::factory() generate an \WebDriver\Exception\UnknownError on DrupalCI and not locally. If I had to guess this is because the error code is different.

After talking to @tedbow we're trying the new assert from #2892440: Provide helper test method to wait for an element to be removed from the page - I don't see why this should work because the screenshots show the settings tray is still active. So I'm hoping this fails.

So locally using chromedriver direct we error code is 64. On linux on DrupalCI using chromedriver direct it's 13 and according to @tedbow this test passes locally whilst using selenium-server to connect to chromedriver so that must be returning a 13 too. So the fix to catch the generic \Exception feel fine as we're asserting on the contents of the message - which is the same locally and with DrupalCI.

Whoops - tested locally but as this doesn't fail locally anymore didn't catch this.

Let's a try a very small iframe.

@tedbow I don't think #5and #6 are related to #3032275: Create a fault-tolerant method for interacting with links and fields in Javascript tests the code here is doing the opposite.

  protected function assertElementUnclickable(NodeElement $element) {
    try {
      $element->click();
      $tag_name = $element->getTagName();
      $this->fail(new FormattableMarkup("@tag_name was clickable when it shouldn't have been", ['@tag_name' => $tag_name]));
    }
    catch (\Exception $e) {
      $this->assertContains('is not clickable at point', $e->getMessage());
    }
  }

I.e. we want the exception we were just catching the wrong exception.

Okay boiling this down to the simplest set of changes for locally passing and random fail fixing. Leaving the drupalci.yml changes is atm to prove that this is the fix.

Let's see if we can change just the width.

Hmmm... maybe we need the extra screen size....interesting,

So let's go back to 1200 width and and making the iframe 1x1 - or maybe #14 was a fluke :( but it seems unlikely.

So #14 which all the different fixes is not failing - reuploading with the unnecessary WebdriverTestBase changes.

So maybe the page resize is not required...

Back to #23. For whatever reason this fix seems to need:

• The iFrame reduced to 1x1
• The screen changed to 1200x1200
• The assertNoElementAfterWait to be changed

Very very weird. Doesn't feel right at all.

Well it might not feel right but the test is still testing and no longer randomly failing. I'd be in favour of committing this and filing a follow-up for more investigation. And obviously we need to push on #2892440: Provide helper test method to wait for an element to be removed from the page too as that's 1/3 of this.

Remove debug stuff.

Created #3056848: Investigate LayoutBuilderDisableInteractionsTest random fails further