Backport of #2820611: FileStorage generated .htaccess doesn't cover PHP 7

CommentFileSizeAuthor
#2 3055805-2.patch357 bytesmcdruid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mcdruid created an issue. See original summary.

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid commented
FileSize
3055805-2.patch357 bytes
mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid commented
Status: Active » Needs review
mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid commented
Issue tags: +Drupal 7.68 target
Ayesh’s picture

Ayesh CreditAttribution: Ayesh commented

Loos good to me.

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid commented
Status: Needs review » Reviewed & tested by the community

Thanks Ayesh!

As this is such a simple change, and has already been committed to D8 (where there's very little difference in the patch), I am going to take that as an RTBC.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

Agreed on RTBC. Tests pass, the change is the same as D8 https://git.drupalcode.org/project/drupal/commit/fd194bb

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Related issues: +#3088836: Rejuvenate D7, a need for more time spent committing and RTBCing Drupal 7 issues
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Related issues: -#3088836: Rejuvenate D7, a need for more time spent committing and RTBCing Drupal 7 issues
mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented
Issue tags: +Already In D8, +Pending Drupal 7 commit

n.b. we need to update issue credit here based on the D8 parent when this is committed.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commented

RTBM - please commit when ready

mcdruid credited Darren Oh.

mcdruid credited David_Rothstein.

mcdruid credited Sweetchuck.

mcdruid credited YesCT.

mcdruid credited mkalkbrenner.

mcdruid credited pwolanin.

mcdruid credited sidharrell.

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented

Adding issue credit from the D8 parent #2820611: FileStorage generated .htaccess doesn't cover PHP 7.

  • mcdruid committed c6f73e2 on 7.x 
    Issue #3055805 by mcdruid, greggles, Ayesh, Darren Oh, David_Rothstein,...
mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit

Thank you everyone that contributed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.